Skip to content

chore: Update POM to Java 25 and rename artifactId/groupId - #11

Merged
fmazmz merged 3 commits into
mainfrom
chore/update-pom-#5
Feb 6, 2026
Merged

chore: Update POM to Java 25 and rename artifactId/groupId#11
fmazmz merged 3 commits into
mainfrom
chore/update-pom-#5

Conversation

@kristinaxm

@kristinaxm kristinaxm commented Feb 5, 2026

Copy link
Copy Markdown

This PR updates the Maven POM for the project.
Renamed groupId from org.example to org.juv25d
Renamed artifactId from JavaTemplate to JavaHttpServer
Updated maven.compiler.release to 25 for Java 25 compilation
Kept existing test dependencies (JUnit, Mockito, AssertJ) for testing

No other functionality is changed.

Branch: chore/update-pom-java25.

Closes #5

Summary by CodeRabbit

  • Chores

    • Updated Java requirement to version 25.
    • Updated project coordinates and naming.
  • Refactor

    • Adjusted internal package structure and namespaces across the codebase.

@kristinaxm kristinaxm self-assigned this Feb 5, 2026
@coderabbitai

coderabbitai Bot commented Feb 5, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Updated Maven coordinates in pom.xml (groupId → org.juv25d, artifactId → JavaHttpServer) and bumped maven.compiler.release from 23 to 25. Aligned Java source and test files by changing package declarations from org.example to org.juv25d.

Changes

Cohort / File(s) Summary
Maven Configuration
pom.xml
Changed groupId to org.juv25d, artifactId to JavaHttpServer, and maven.compiler.release from 2325.
Application Sources
src/main/java/.../App.java, src/main/java/org/juv25d/SocketServer.java
Updated package declarations from org.exampleorg.juv25d. No logic changes; minor EOF newline addition.
Tests
src/test/java/.../AppTest.java, src/test/java/.../AppIT.java
Updated package declarations from org.exampleorg.juv25d. Tests otherwise unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through pom and files with cheer,
Names rearranged, the path is clear,
From twenty-three to twenty-five we bound,
Packages aligned, no bugs were found,
A little thump — the build draws near!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating the POM to Java 25 and renaming Maven coordinates (artifactId/groupId).
Linked Issues check ✅ Passed The PR directly addresses issue #5 by updating pom.xml with new Maven coordinates and Java 25 compiler configuration as required.
Out of Scope Changes check ✅ Passed All changes are in-scope: package declarations updated to match new namespace, pom.xml configuration updated, and test files updated accordingly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-pom-#5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pom.xml`:
- Around line 11-12: pom.xml sets maven.compiler.release to 25 but the repo
lacks any CI or toolchain configuration to guarantee JDK 25; update the CI
(e.g., .github/workflows) to use JDK 25 (actions/setup-java or equivalent) or
add a Maven toolchains.xml and corresponding <pluginManagement>/<plugin>
configuration so the build uses JDK 25, or alternatively lower
<maven.compiler.release> to a supported JDK; reference the
maven.compiler.release property in pom.xml and the repository CI workflow or a
new toolchains.xml when making the change.
🧹 Nitpick comments (1)
pom.xml (1)

7-8: Maven coordinates references are clean in docs, CI, and consuming modules.

No lingering references to the old Maven coordinates (org.example:JavaTemplate) were found in documentation, CI/CD configuration, or other pom.xml files. However, the Java source files still declare package org.example; — while these are not Maven coordinates, consider updating the package names to org.juv25d for consistency with the new groupId.

Comment thread pom.xml

@fmazmz fmazmz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Make sure to update the folder name "example" to match the groupId -> "juv25d"

fmazmz
fmazmz previously approved these changes Feb 5, 2026

@fmazmz fmazmz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire!

@LinusWestling

Copy link
Copy Markdown

Speed of light development

LinusWestling
LinusWestling previously approved these changes Feb 6, 2026
@fmazmz
fmazmz dismissed stale reviews from LinusWestling and themself via db75355 February 6, 2026 08:03
@fmazmz

fmazmz commented Feb 6, 2026

Copy link
Copy Markdown
Member

@LinusWestling can you approve the new changes please so we can merge this!

@fmazmz
fmazmz merged commit 70db6c7 into main Feb 6, 2026
3 checks passed
@fmazmz
fmazmz deleted the chore/update-pom-#5 branch February 6, 2026 14:10
fmazmz added a commit that referenced this pull request Feb 7, 2026
* chore: Update POM to Java 25 and rename artifactId/groupId

* update folder name from example to juv25d

---------

Co-authored-by: WHITEROSE <firasmoussa60@gmail.com>
fmazmz added a commit that referenced this pull request Feb 7, 2026
* http parser

* Bunny fixes. (only using input stream to recieve requests)

* Bunny review improvements

* Improved http parser ReadLine helper method to eliminate dependency on mark() and reset(). Implemented handleClient() using socket as a try-with-resources to avoid memory leakage in case of exception thrown by httpparser-methods.

* NumberFormatException fix on line 53 -> 60

* chore: Update POM to Java 25 and rename artifactId/groupId (#11)

* chore: Update POM to Java 25 and rename artifactId/groupId

* update folder name from example to juv25d

---------

Co-authored-by: WHITEROSE <firasmoussa60@gmail.com>

* resolve conflicts

---------

Co-authored-by: Kristina <kristina0x7@gmail.com>
Co-authored-by: WHITEROSE <firasmoussa60@gmail.com>
@coderabbitai coderabbitai Bot mentioned this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Byggkonfiguration (pom.xml / dependencies)

3 participants