chore: Update POM to Java 25 and rename artifactId/groupId - #11
Conversation
📝 WalkthroughWalkthroughUpdated Maven coordinates in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pom.xml`:
- Around line 11-12: pom.xml sets maven.compiler.release to 25 but the repo
lacks any CI or toolchain configuration to guarantee JDK 25; update the CI
(e.g., .github/workflows) to use JDK 25 (actions/setup-java or equivalent) or
add a Maven toolchains.xml and corresponding <pluginManagement>/<plugin>
configuration so the build uses JDK 25, or alternatively lower
<maven.compiler.release> to a supported JDK; reference the
maven.compiler.release property in pom.xml and the repository CI workflow or a
new toolchains.xml when making the change.
🧹 Nitpick comments (1)
pom.xml (1)
7-8: Maven coordinates references are clean in docs, CI, and consuming modules.No lingering references to the old Maven coordinates (
org.example:JavaTemplate) were found in documentation, CI/CD configuration, or otherpom.xmlfiles. However, the Java source files still declarepackage org.example;— while these are not Maven coordinates, consider updating the package names toorg.juv25dfor consistency with the new groupId.
fmazmz
left a comment
There was a problem hiding this comment.
Great!
Make sure to update the folder name "example" to match the groupId -> "juv25d"
|
Speed of light development |
|
@LinusWestling can you approve the new changes please so we can merge this! |
* chore: Update POM to Java 25 and rename artifactId/groupId * update folder name from example to juv25d --------- Co-authored-by: WHITEROSE <firasmoussa60@gmail.com>
* http parser * Bunny fixes. (only using input stream to recieve requests) * Bunny review improvements * Improved http parser ReadLine helper method to eliminate dependency on mark() and reset(). Implemented handleClient() using socket as a try-with-resources to avoid memory leakage in case of exception thrown by httpparser-methods. * NumberFormatException fix on line 53 -> 60 * chore: Update POM to Java 25 and rename artifactId/groupId (#11) * chore: Update POM to Java 25 and rename artifactId/groupId * update folder name from example to juv25d --------- Co-authored-by: WHITEROSE <firasmoussa60@gmail.com> * resolve conflicts --------- Co-authored-by: Kristina <kristina0x7@gmail.com> Co-authored-by: WHITEROSE <firasmoussa60@gmail.com>
This PR updates the Maven POM for the project.
Renamed groupId from org.example to org.juv25d
Renamed artifactId from JavaTemplate to JavaHttpServer
Updated maven.compiler.release to 25 for Java 25 compilation
Kept existing test dependencies (JUnit, Mockito, AssertJ) for testing
No other functionality is changed.
Branch: chore/update-pom-java25.
Closes #5
Summary by CodeRabbit
Chores
Refactor