Skip to content

Add ADR for IP-based request filtering - #135

Merged
HerrKanin merged 2 commits into
mainfrom
docs/adr-ip-filter
Feb 25, 2026
Merged

Add ADR for IP-based request filtering#135
HerrKanin merged 2 commits into
mainfrom
docs/adr-ip-filter

Conversation

@HerrKanin

@HerrKanin HerrKanin commented Feb 25, 2026

Copy link
Copy Markdown

Adds an ADR documenting the initial design and rationale for IP-based request filtering (whitelist, blacklist, open mode).
No functional changes.

Summary by CodeRabbit

  • Documentation
    • Added an architectural decision record describing server-wide IP modes (Whitelist, Blacklist, Open), design rationale, decision, consequences, and alternatives.
    • Updated the ADR index to include the new entry and its acceptance date.

@HerrKanin HerrKanin self-assigned this Feb 25, 2026
@coderabbitai

coderabbitai Bot commented Feb 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0b3f27 and 5a2c63f.

📒 Files selected for processing (1)
  • docs/adr/ADR-002-ip-based-request-filtering.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/adr/ADR-002-ip-based-request-filtering.md

📝 Walkthrough

Walkthrough

Adds ADR-002 describing a server-wide IP-based request filtering design with three modes (Whitelist, Blacklist, Open) and updates the ADR index; documentation-only changes, no code implementation.

Changes

Cohort / File(s) Summary
ADR Document
docs/adr/ADR-002-ip-based-request-filtering.md
New ADR specifying a global IP filter with three modes (Whitelist, Blacklist, Open), exact IP matching, decision rationale, consequences, alternatives, and noted precedence/ambiguity concerns.
ADR Index
docs/adr/README.md
Added ADR-002 entry to the ADR index table with status "Accepted" and date 2026-02-25.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

documentation

Suggested reviewers

  • annikaholmqvist94
  • Cavve
  • bamsemats
  • LinusWestling

Poem

🐇 I prance through docs with careful paw,
A whitelist, blacklist, open door—hurrah!
Three modes penned in tidy view,
Early gates to let in few or slew.
Cheers from this rabbit: hops and codify anew. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Add ADR for IP-based request filtering' clearly and concisely describes the main change—adding a new architectural decision record document about IP-based request filtering. The title is directly related to the changeset, which adds two documentation files (the ADR document itself and an update to the README index).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/adr-ip-filter

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/adr/ADR-002-ip-based-request-filtering.md`:
- Line 13: Fix the typos in ADR-002-ip-based-request-filtering.md: replace the
word "rout" with "route" in the Key Decision text, change "separate
configurations approaches" to "separate configuration approaches", and change
"Potential ambiguous" to "Potential ambiguity" so the phrases read correctly and
improve readability.
- Line 17: Replace the non-standard Markdown horizontal rule markers ("--") in
the ADR-002-ip-based-request-filtering.md document with the standard three-dash
horizontal rule ("---"); search for occurrences of "--" used as separators
(e.g., the instances currently separating sections) and update them to "---" to
ensure consistent rendering across Markdown processors.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad74e89 and d0b3f27.

📒 Files selected for processing (2)
  • docs/adr/ADR-002-ip-based-request-filtering.md
  • docs/adr/README.md

Comment thread docs/adr/ADR-002-ip-based-request-filtering.md Outdated
Comment thread docs/adr/ADR-002-ip-based-request-filtering.md Outdated

@jesperlarsson1910 jesperlarsson1910 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only meant to reflect the first implimentation right? It doesn't fully reflect the changes from #79 and I'm currently working on #98.

@HerrKanin

Copy link
Copy Markdown
Author

This is only meant to reflect the first implimentation right? It doesn't fully reflect the changes from #79 and I'm currently working on #98.

Yes, exactly.
This ADR documents the initial IP filter design and the decision as it was implemented at that time.

The changes discussed in #79 and the ongoing work in #98 extend the behavior beyond the initial scope and can be documented separately once finalized.

@jesperlarsson1910 jesperlarsson1910 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@DennSel DennSel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIx the spelling suggested by coderabbit and I'll approve

@HerrKanin

Copy link
Copy Markdown
Author

Spelling suggested by coderabbit is fixed

@HerrKanin
HerrKanin merged commit 1e443d8 into main Feb 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants