Fix PiTest by defining argLine and removing invalid Mockito javaagent - #27
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughMaven POM configuration updated to introduce a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pom.xml`:
- Line 17: The POM uses the Maven property syntax `${argLine}` which is resolved
at parse time and prevents JaCoCo's prepare-agent from appending its -javaagent;
change the argLine element to use Maven late-property-replacement syntax
`@{argLine}` (replace occurrences of `${argLine}` with `@{argLine}` where
argLine is declared/used) so the default empty `<argLine/>` stays effective and
JaCoCo's prepare-agent can inject the JVM agent when coverage is enabled.
🧹 Nitpick comments (1)
pom.xml (1)
67-76: Remove themaven-dependency-plugin:propertiesexecution.The
propertiesgoal creates Maven properties from artifact coordinates, but no artifact-path properties (e.g.,${org.mockito:mockito-core:jar}) are defined or used anywhere in the POM. Since the javaagent injection has been removed, this plugin execution serves no purpose and should be deleted.
|
@addee1 an approval would be awesome 👯 👯♀️ :) |
now fully working pitest.
had to do some small fixes.
closes #26
Summary by CodeRabbit