Skip to content

Fix PiTest by defining argLine and removing invalid Mockito javaagent - #27

Merged
kristinaxm merged 2 commits into
mainfrom
pom/refactor-pitest
Feb 10, 2026
Merged

Fix PiTest by defining argLine and removing invalid Mockito javaagent#27
kristinaxm merged 2 commits into
mainfrom
pom/refactor-pitest

Conversation

@kristinaxm

@kristinaxm kristinaxm commented Feb 10, 2026

Copy link
Copy Markdown

now fully working pitest.
had to do some small fixes.

closes #26

Summary by CodeRabbit

  • Chores
    • Updated test build configuration to simplify Java Virtual Machine argument composition during test execution.

@kristinaxm kristinaxm self-assigned this Feb 10, 2026
@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@kristina0x7 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Maven POM configuration updated to introduce a new argLine property and modify the maven-surefire-plugin configuration. The change replaces the previous @{argLine} placeholder with ${argLine} and removes the inline mockito javaagent injection from the test JVM arguments.

Changes

Cohort / File(s) Summary
Maven Configuration
pom.xml
Added argLine property to <properties> section. Updated maven-surefire-plugin configuration to use ${argLine} variable instead of @{argLine} and removed the -javaagent:${org.mockito:mockito-core:jar} injection, keeping only -Xshare:off.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • bamsemats
  • VonAdamo

Poem

🐰 A Maven burrow, neat and spry,
Where argLine hops beneath the sky,
No agent now, just sharing's off,
The warren tests with nary scoff!
Properties dance, refactored bright,
Configuration feels just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: fixing PiTest by defining argLine and removing invalid Mockito javaagent, which directly aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pom/refactor-pitest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pom.xml`:
- Line 17: The POM uses the Maven property syntax `${argLine}` which is resolved
at parse time and prevents JaCoCo's prepare-agent from appending its -javaagent;
change the argLine element to use Maven late-property-replacement syntax
`@{argLine}` (replace occurrences of `${argLine}` with `@{argLine}` where
argLine is declared/used) so the default empty `<argLine/>` stays effective and
JaCoCo's prepare-agent can inject the JVM agent when coverage is enabled.
🧹 Nitpick comments (1)
pom.xml (1)

67-76: Remove the maven-dependency-plugin:properties execution.

The properties goal creates Maven properties from artifact coordinates, but no artifact-path properties (e.g., ${org.mockito:mockito-core:jar}) are defined or used anywhere in the POM. Since the javaagent injection has been removed, this plugin execution serves no purpose and should be deleted.

Comment thread pom.xml Outdated
@bamsemats
bamsemats self-requested a review February 10, 2026 12:49
@addee1
addee1 self-requested a review February 10, 2026 12:49

@addee1 addee1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done Kristina :)

@kristinaxm
kristinaxm requested review from addee1 February 10, 2026 12:52
@kristinaxm

Copy link
Copy Markdown
Author

@addee1 an approval would be awesome 👯 👯‍♀️ :)

@kristinaxm
kristinaxm merged commit 019e4c4 into main Feb 10, 2026
2 checks passed
@kristinaxm
kristinaxm deleted the pom/refactor-pitest branch February 10, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants