Create release tag v1.0.0-beta - #58
Conversation
bamsemats
left a comment
There was a problem hiding this comment.
Won't we need a value=latest, or is that irrelevant for this project?
|
@coderabbitai ignore |
📝 WalkthroughWalkthroughThis PR updates the GitHub Actions Docker release workflow to trigger on tag pushes matching Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Dockerfile`:
- Around line 11-17: The Dockerfile runs the JRE as root; create and switch to a
non-root user in the runtime stage so the container does not run as root. Add
steps in the final stage to create a dedicated user/group (e.g., app user),
ensure the copied artifact ownership is changed to that user (affecting the COPY
/*.jar app.jar step), and add a USER directive before the ENTRYPOINT so java
-jar app.jar runs as the non-root user; keep WORKDIR and ENTRYPOINT intact but
ensure file permissions allow the new user to execute the jar.
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
✅ Actions performedReviews paused. |
|
@bamsemats not needed for now atleast. |
Reverted pom changes.
Fix in docker-release.yml to run on tag push
Summary by CodeRabbit