Skip to content

Create release tag v1.0.0-beta - #58

Merged
fmazmz merged 6 commits into
mainfrom
release/v1.0.0-beta
Feb 12, 2026
Merged

Create release tag v1.0.0-beta#58
fmazmz merged 6 commits into
mainfrom
release/v1.0.0-beta

Conversation

@fmazmz

@fmazmz fmazmz commented Feb 12, 2026

Copy link
Copy Markdown
Member

Reverted pom changes.
Fix in docker-release.yml to run on tag push

Summary by CodeRabbit

  • Chores
    • Release automation now triggers on tag pushes (v* tags) instead of release creation.
    • Container base images updated to a newer Java runtime and build image for improved platform and security.
    • Build packaging updated so JARs include a main class and classpath in the manifest, improving standalone execution.
    • VCS ignore rules extended to exclude META-INF artifacts.

@bamsemats
bamsemats marked this pull request as ready for review February 12, 2026 11:38
@bamsemats
bamsemats self-requested a review February 12, 2026 11:39
@ithsjava25 ithsjava25 deleted a comment from coderabbitai Bot Feb 12, 2026

@bamsemats bamsemats left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need a value=latest, or is that irrelevant for this project?

@fmazmz

fmazmz commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai ignore

@ithsjava25 ithsjava25 deleted a comment from coderabbitai Bot Feb 12, 2026
@coderabbitai

coderabbitai Bot commented Feb 12, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates the GitHub Actions Docker release workflow to trigger on tag pushes matching v* and adjusts docker metadata inputs; upgrades the Dockerfile Temurin base images from 21 to 25; adds META-INF to .gitignore; and adds a manifest configuration to pom.xml specifying main class and classpath entries.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/docker-release.yml
Trigger changed from release creation to tag push (v*); docker/metadata-action inputs updated to derive tags from tag events (type=ref,event=tag).
Dockerfile (build & runtime)
Dockerfile
Base images updated from maven:3.9-eclipse-temurin-21 and eclipse-temurin:21-jre-alpine to Temurin 25 variants; build steps and ENTRYPOINT unchanged.
Maven packaging
pom.xml
Added maven-jar-plugin configuration to emit a manifest with addClasspath=true and Main-Class=org.juv25d.App.
Repository ignore rules
.gitignore
Added META-INF to ignore patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • LinusWestling
  • johanbriger

Poem

🐰 A tiny hop at tag-time's call,
The workflow wakes and changes all,
From twenty-one to twenty-five I leap,
Manifests tucked in jars to keep,
I nibble code and humbly fall.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes creating a release tag, but the actual changes involve updating Docker workflows, base images, and Maven configurations—not just creating a tag. Update the title to better reflect the main changes, such as 'Update Java version to 21 and configure Docker release workflow' or 'Update base images and Docker release trigger'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/v1.0.0-beta

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@Dockerfile`:
- Around line 11-17: The Dockerfile runs the JRE as root; create and switch to a
non-root user in the runtime stage so the container does not run as root. Add
steps in the final stage to create a dedicated user/group (e.g., app user),
ensure the copied artifact ownership is changed to that user (affecting the COPY
/*.jar app.jar step), and add a USER directive before the ENTRYPOINT so java
-jar app.jar runs as the non-root user; keep WORKDIR and ENTRYPOINT intact but
ensure file permissions allow the new user to execute the jar.

Comment thread Dockerfile
@coderabbitai

coderabbitai Bot commented Feb 12, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":404,"request":{"method":"PATCH","url":"https://api.github.com/repos/ithsjava25/project-webserver-juv25d/issues/comments/3890429458","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: review paused by coderabbit.ai -->\n\n> [!NOTE]\n> ## Reviews paused\n> \n> Use the following commands to manage reviews:\n> - `@coderabbitai resume` to resume automatic reviews.\n> - `@coderabbitai review` to trigger a single review.\n> \n> Use the checkboxes below for quick actions:\n> - [ ] <!-- {\"checkboxId\": \"7f6cc2e2-2e4e-497a-8c31-c9e4573e93d1\"} --> ▶️ Resume reviews\n> - [ ] <!-- {\"checkboxId\": \"e9bb8d72-00e8-4f67-9cb2-caf3b22574fe\"} --> 🔍 Trigger review\n\n<!-- end of auto-generated comment: review paused by coderabbit.ai -->\n<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: review in progress by coderabbit.ai -->\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n> \n> \n> ```ascii\n>  __________________________________________________\n> < Deploying the charm offensive against your bugs. >\n>  --------------------------------------------------\n>   \\\n>    \\   (\\__/)\n>        (•ㅅ•)\n>        /   づ\n> ```\n> \n> <sub>✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.</sub>\n\n<!-- end of auto-generated comment: review in progress by coderabbit.ai -->\n<!-- usage_tips_start -->\n\n> [!TIP]\n> <details>\n> <summary>You can disable sequence diagrams in the walkthrough.</summary>\n> \n> Disable the `reviews.sequence_diagrams` setting to disable sequence diagrams in the walkthrough.\n> \n> </details>\n\n<!-- usage_tips_end -->\n<!-- walkthrough_start -->\n\n<details>\n<summary>📝 Walkthrough</summary>\n\n\\n\\n<details>\\n<summary>📝 Walkthrough</summary>\\n\\n## Walkthrough\\n\\nThis PR modifies the GitHub Actions Docker release workflow to trigger on tag pushes matching `v*` instead of release creation events, and updates the Docker metadata action to derive tags from tag events rather than short ref names.\\n\\n## Changes\\n\\n|Cohort / File(s)|Summary|\\n|---|---|\\n|**GitHub Actions Workflow Configuration** <br> `.github/workflows/docker-release.yml`|Modified workflow trigger from release creation to tag pushes (v*) and updated Docker metadata generation to extract tags from tag events (changed `type=ref,event=release` to `type=ref,event=tag`).|\\n\\n## Estimated code review effort\\n\\n🎯 2 (Simple) | ⏱️ ~10 minutes\\n\\n## Possibly related issues\\n\\n- **Issue `#55`**: Directly addressed by this PR—the workflow change enables the objective of creating/pushing a v.* tag to automatically trigger a release by switching the trigger mechanism from releases to tag pushes.\\n\\n## Possibly related PRs\\n\\n- **PR `#8`**: Directly related—modifies the same `.github/workflows/docker-release.yml` workflow with identical intent to switch triggering from release events to tag events and update Docker metadata generation accordingly.\\n\\n## Suggested reviewers\\n\\n- LinusWestling\\n- johanbriger\\n\\n## Poem\\n\\n> 🐰 A tag now sparks the Docker dance,\\n> No releases need a second glance,\\n> The workflow hops where tags take flight,\\n> Metadata follows, smooth and tight!\\n\\n</details>\\n\\n\n\n</details>\n\n<!-- walkthrough_end -->\n\n<!-- pre_merge_checks_walkthrough_start -->\\n\\n<details>\\n<summary>🚥 Pre-merge checks | ✅ 2 | ❌ 1</summary>\\n\\n<details>\\n<summary>❌ Failed checks (1 warning)</summary>\\n\\n|  Check name | Status     | Explanation                                                                                                                                                                                                                                                   | Resolution                                                                                                                                                                          |\\n| :---------: | :--------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\\n| Title check | ⚠️ Warning | The PR title 'Create release tag v1.0.0-beta' does not match the actual changes made. The changeset modifies the Docker workflow to trigger on tag pushes instead of creating a release tag. The title is misleading about what the PR actually accomplishes. | Update the title to reflect the actual changes, such as 'Fix docker-release workflow to trigger on tag push' or 'Update Docker release workflow trigger from release to tag event'. |\\n\\n</details>\\n<details>\\n<summary>✅ Passed checks (2 passed)</summary>\\n\\n|     Check name     | Status   | Explanation                                                                                                |\\n| :----------------: | :------- | :--------------------------------------------------------------------------------------------------------- |\\n|  Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled.                                                |\\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\\n\\n</details>\\n\\n<sub>✏️ Tip: You can configure your own custom pre-merge checks in the settings.</sub>\\n\\n</details>\\n\\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Post copyable unit tests in a comment\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `release/v1.0.0-beta`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=ithsjava25/project-webserver-juv25d&utm_content=58)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAwhRLUJJD+XmiIQbhoRJASAIwaAAyJYAIkkZCQBgByjqkUXACsABwZBgCqNgAyXLC4uNyIHAD0TUTqsNgCGkzMTe2IQmgSaABMBU28+CJiYADuJALhFFIUYELYEmO0E9geHk3FpWVLXABmzGgAXsyXpQDK+NgUDEECVBgMsFwhAeFNcYlkql0oAkwhgzlIuEgb0wny4F3gWEyd0iuGwjX43DIpT8ARo9GoXBGCRGADYwCSwLERtBYrEOABmUkcWIJABaRgAItIGBR4NxxPgMBwDFAbCQVvieCxGLBMKREBpRZAAGLwAAeKCwtHwDAA1pQwD8wiQNLJmB5IARgtgsEKrVEeOjYEqDBZID4WMx1JA2IhEFFpPZHBcXEYoAJHNxpcwYpREPB7ad8HxjeFlf5JTG4xQE0LlacNVwdfrKMESKFwpBZim9acPPhZlb8Da7VhItFuM6C0XINhuLRAg7ov5TlrICWDamK78gjWKHWG7M3PhIbAy7h1wpWOpkIhYI30FhEep4GhLdwZSs81hI8xo5vqNWwsHFiQAI7YdgeeSZyj4gAaI96FwGtIELdUg2tTcgk5XUp3LSs51retD2tMgHH8FAoQoW1kHtDsnX3INMHodEoK3JgKH8MRh3LU5KDIF5XX0YxwCgMh6HwMc0DwQhSHIKgpR6NgME4Hg+EEaZxCkGR5CYJQqFUdQtB0ViTCgOBUFQTAcAIYgyGUYSvXYb40CbBwnBcaF5MUZRlM0bRdDAQw2NMAwNDaTdOiaedF0bRAmknQ001Nc0PBFAAiaK3UsABBABJAzBMCehLNDeRuNleVpHDSBxW4Dw0BeZAYOrFClytPkiFIPhTgoGVQsYfxqETdsW0Irt90gAAKDBDw8JAaAwZBkz4DtkAuXBPkRaIJAAKgASiVKAygHQJkDg0s+DYSJB3SASjLa5sJ0oSQIiiUaGtjQiJXYZBEUQGg0C4nj7APCgcJIMcMDQNhetwWQsQAXlHAC7rE4HCIkUqgZIUHvoA362GB/cU1wZajHMeKPBoIS2tKjqtyUBgivxoV8LHEh1UvT66H4PguwEQaGEgdhT1y5UshbJmWbZmn0boHZmfgVmSbJ1qKerRjfUUeBCzoV1KkRINPhy2guAAagAFiaMBtaMABRJ74Cm+mFKCTN4BIJtvrG8SAFk6HgRwDGiyLwxctyOIwV69P4wyhPNkyxLMiyQ2ceQ5AURSVDURy1K9jTt29XAAH14FoRA06tm26DTp7nChViDGThhYgYWgAHZTliUkSAKWgBDJARTlOUkq9GEY0FJU5K6r2hSQKBI0ASUlBxetBnNcsuvXUDOs5ziVrfmWg0846fS/YiSSDTtgKFINPPlEPVs8Lz7N4MABvAwMkipBbAAIQbUtaE9Vh2CsfAnroSKznPcIAFb6QEimjXYtBn7wVsH/cCACSBALvkgAA8isPktAlAYBgacOBCCQG0EzjYW0W0UR8gwEQRAPh1z6hgbgXC8DgGRXwbQQhGB3C4C8JQk+NC6G4MYQQohPI+QCjapw6h/8PCAIYYNDABpaAJX9F+RAJCYHRV4UVJ6oi9TigcLjRAMCADawCMg3wyKYkBx99RZD+iQFR3JEC8n5IKLAmjIq4LMaA1E6JuFfjcaYyK1NCqYElpgrgkVNH2D1PyLE9AoCeiUDYOO6hACYBMgBARBYBgC8FIS06VI4oGQGQFQXhaAaFcUYvxzA7IqNmM4DAs0ylmLvimeAbRfoeE0VYtgKilD2KEU4j2ZiAC+viTGNMihYvUnSbGhLYV4WUXDfF30LmiPR4jJGNJAQEoqv1+kzK3LYK0ngggAHJcRDiatDeISQEgpDSGgY5E58BBn6lCKanwrRbmKmic82UyFBguEoDQMBKJyj+eEV5csFalS3FtBCflUJNmgtVWq/B2yOi6uuB6I1np+15HiWa6BEKzmHECuAEQjn5N9EgUI+CyHoAEI8KEsw5RQjKgcr52Bzw/nQAwHohUkCYtKYskB/hED4A8HgNqKi1r7QiFucQ7CIgtlHF4WiZUOU/LVmCoCDh3kvmOWqTUwVVhNXhZVJFLSUUEXRc6B5KZIDHJlUOWFZZTUVTQsiss9VGozhNCdW6UgxLHKFeUu+lSlDVNqfU4VkUaJCkLEQJ40zYESPoRsyKzTWnng6dYlRCqvADNMcM8poz3ETKmbY3UT1SHRE9CsQMDSxnLK8VwWhPjQ2bJpts4JKjubgVtGIAm4FHi+3HGVLVpB6CFi8ITNmwwJVDhLNWglTB62kCBXcSJ3BuAEqXbQld+A11BAmSG9NorxWSqFCogA6nyGgjyGDLrIaNe1ZVTgDqcZNJACY6UwRui2AM4hECnHkOOw9yhSAfNFQeDwJTG3uPDcmyKNSKB1LIfBvxmbETZqoZM3NoS901r0eUwZwCAC6aiwi4FsHYhxwir2hO1trF4DAx4AE5tanDGAyKuVdtaiBICQUk2sigFBGAIIoDBSQMBUAUKupJhOxC46JtjEnTh8frlXUTsQihoCKHXEYFc0BscbZFdR1GbCzKQwIbWBRSRsYZGMEgIwGTN1iGgNA2Da5ae+iQJj/HaCxD4y9UTHdDOOYKHp0YaAGQkFiAUNjzmEhyYKAyauIxTOEdmnWiDJAEpiUoG0lEgQYFX1I6RreEAd570oIfCZ2cN7qW3rxAgaduC8XCAXVEu9z7Fy9tfMzVGrAdboHFXA4oJArzoO/VOnpbS4D/gkCrycWv4DayNrrgR16jv0EAA= -->\n\n<!-- internal state end -->"},"request":{"retryCount":1}},"response":{"url":"https://api.github.com/repos/ithsjava25/project-webserver-juv25d/issues/comments/3890429458","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 12 Feb 2026 11:45:20 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"issues=write; pull_requests=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; format=json","x-github-request-id":"502C:E9079:2F9893E:CD76339:698DBD50","x-ratelimit-limit":"12500","x-ratelimit-remaining":"12335","x-ratelimit-reset":"1770898312","x-ratelimit-resource":"core","x-ratelimit-used":"165","x-xss-protection":"0"},"data":{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#update-an-issue-comment","status":"404"}}}

@coderabbitai

coderabbitai Bot commented Feb 12, 2026

Copy link
Copy Markdown
✅ Actions performed

Reviews paused.

@fmazmz fmazmz mentioned this pull request Feb 12, 2026
@fmazmz

fmazmz commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

@bamsemats not needed for now atleast.
It is better to use excplicit tag instead of "latest" so we are always sure what version is being released.

@fmazmz fmazmz linked an issue Feb 12, 2026 that may be closed by this pull request

@mattknatt mattknatt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets go!

@simonforsberg simonforsberg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup looks good!

@fmazmz
fmazmz merged commit b088497 into main Feb 12, 2026
3 checks passed
@fmazmz
fmazmz deleted the release/v1.0.0-beta branch February 12, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RELEASE 1.0.0-beta

4 participants