Name the CosmosDB emulator image, as the other fixtures already do - #45
Merged
Conversation
Testcontainers has deprecated the parameterless builders in favour of the ones that take an image, and the CosmosDB fixture was the last using the old form. Two warnings, one per target framework. The Redis, PostgreSQL and SQL Server fixtures beside it already name their image. This makes the emulator match, and makes the version the tests run against visible in the file rather than decided by the package. Found on a cleaned build. An incremental one had reported none, which is the second time today that difference has hidden a warning I had just introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testcontainers deprecated the parameterless builders in favour of the ones taking an image. The CosmosDB fixture was the last on the old form — 2 warnings, one per target framework.
The Redis, PostgreSQL and SQL Server fixtures beside it already name their image. This makes the emulator match, and puts the version the tests run against in the file rather than leaving it to the package.
Found on a cleaned build. An incremental one reported none — the second time today that difference has hidden a warning I had just introduced, and the reason I now only quote warning counts after
dotnet clean.Verified: cold build is 0 errors / 0 warnings, and the 9 CosmosDB emulator tests still pass.