Give the browser assertions a timeout suited to a loaded runner - #51
Merged
Conversation
Two release runs failed on assertions that pass on every pull request. The difference is load, not correctness: the release workflow runs this suite straight after eleven hundred unit tests across two frameworks, and Playwright's default five-second expect timeout is tuned for a developer's machine driving a single page. Every assertion here waits on a Blazor Server round trip. Raised to twenty seconds once, in the fixture, rather than per call, so no future assertion has to remember. A test that is genuinely broken still fails; it just no longer fails for being on a busy machine. Reproduced the condition locally by running the full E2E suite while both unit suites ran alongside it: 53/53.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release runs failed on assertions that pass on every PR. The difference is load: the release workflow runs the E2E suite straight after 1,116 unit tests across two frameworks, and Playwright's default 5s expect timeout assumes a developer's machine driving one page — every assertion here waits on a Blazor Server round trip.
Raised to 20s once in the fixture rather than per call. A genuinely broken test still fails; it just stops failing for being on a busy machine.
Reproduced locally by running the full E2E suite concurrently with both unit suites: 53/53.