v0.9 Phase 2: Sidebar + shell layout#65
Merged
Merged
Conversation
- New Sidebar component (280px sticky) with brand, active town card, per-category nav with donated/total counts, footer (Export + Settings) - App shell CSS in index.css: .ac-app grid (280px 1fr), max-width 1440px, stacks above main below 980px - ACCanvas refactored to mount Sidebar + <main className="ac-main">; outer gradient/grid background removed in favor of --bg - Hemisphere toggle relocated to sidebar town card for ACNH (was in MuseumHeader); will move into TownManager in Phase 4 - Switch town stub: cycles between towns or opens CreateTownModal — full TownManager drawer ships in Phase 4 - Deleted: MuseumHeader, TabBar, TownSwitcher - CHANGELOG + CLAUDE.md updated Per docs/v0.9-plan.md Phase 2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- package.json version → 0.9.0-beta (footer/UI version flows from here via vite define) - README.md: clarify v0.8.2-alpha is last stable, v0.9.0-beta in active dev - CLAUDE.md: update current-version line to reflect Phase 2 shipped - docs/v0.9-plan.md: mark Phase 1 (PR #63) and Phase 2 (PR #65) as shipped - README sea-creatures note updated (TabBar → sidebar nav) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
Pushed follow-up commit Version bump →
Doc sweep
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of v0.9.0-beta per
docs/v0.9-plan.md§ Phase 2 — Sidebar + Shell Layout.Replaces
MuseumHeader+TabBar+TownSwitcherwith a single 280px sticky leftSidebarand a CSS-grid app shell. React Router routes and URL structure are fully preserved.What changed
src/components/Sidebar.tsx— brand mark/wordmark, active-town card, vertical nav (<NavLink>) with per-categorydonated/totalcounts and active-state styling, footer with Export CSV + Settings.src/index.css—.ac-app(grid-template-columns: 280px 1fr,max-width: 1440pxcentered),.ac-sidebar(sticky, full height, scrollable),.ac-main(32×48px padding, 24×20px below 980px), nav/town/brand/footer styles, and the 980px breakpoint that stacks sidebar above main.ACCanvas.tsxrefactored — old wrapper div + parchment gradient/grid background removed; mountsSidebar+<main className="ac-main">. Hydration guard, modals, and tab switch are all unchanged.gameId in {ACNL, ACNH}anddata.sea_creatures.length > 0.MuseumHeader).MuseumHeader.tsx,TabBar.tsx,TownSwitcher.tsx.Decisions
docs/v0.9-plan.md("No user-facing copy should say Curator").TownManager): if no other towns → opensCreateTownModal; one other → activates it; multiple →window.promptpicker. Lightweight bridge so users keep town-switching between Phase 2 and Phase 4.TownSwitcher). Both reuse the existing modals, which Phase 4 retires.MuseumHeaderand removing it cold would regress v0.8 functionality. Phase 4 moves it intoTownManager./settings(route lands in Phase 3) — clicking it now will fall through to the catch-all redirect.CategoryProgressonceProgressMeterships in Phase 6. Phase 2 uses just nav counts.Test plan
npm run buildpasses (tsc + vite build, zero errors)npm testpasses (59/59)🤖 Generated with Claude Code