fix #267, migrating JUnit 4 to JUnit 5#292
Merged
lukasj merged 10 commits intojakartaee:masterfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: Antonio Santos Izaguirre <antoniosanct@gmail.com>
Signed-off-by: Antonio Santos Izaguirre <antoniosanct@gmail.com>
lukasj
reviewed
Feb 17, 2024
Contributor
lukasj
left a comment
lukasj
left a comment
There was a problem hiding this comment.
let's wait with this after 4.0.2 gets out
Signed-off-by: Antonio <antoniosanct@gmail.com>
Signed-off-by: Antonio <antoniosanct@gmail.com>
lukasj
reviewed
Feb 5, 2026
Contributor
laurentschoelens
left a comment
laurentschoelens
left a comment
There was a problem hiding this comment.
Globally good for me :
- see remarks one some files / lines of code
- beware of copyright header updates (on all file w/ good copyright if not from oracle
Copyright (c) 2026 Contributors to the Eclipse Foundation. All rights reserved.)
jaxb-api-test/src/test/java/jakarta/xml/bind/test/JAXBContextTest.java
Outdated
Show resolved
Hide resolved
jaxb-api-test/src/test/java/jakarta/xml/bind/test/JAXBContextTest.java
Outdated
Show resolved
Hide resolved
…ule-info.java that conflicts with surefire-plugin execution
lukasj
approved these changes
Feb 27, 2026
Contributor
lukasj
left a comment
lukasj
left a comment
There was a problem hiding this comment.
Let's merge this. Minor things, should there be any, can be fixed in extra PRs
Contributor
Author
|
Thanks, @lukasj !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lukasj
I wish this PR would be useful for the project.
Regards,
Antonio.