Fix #316, Unable to override JAXBContextFactory through properties#317
Merged
m0mus merged 4 commits intojakartaee:masterfrom Apr 30, 2025
Merged
Fix #316, Unable to override JAXBContextFactory through properties#317m0mus merged 4 commits intojakartaee:masterfrom
m0mus merged 4 commits intojakartaee:masterfrom
Conversation
…erties Remove jakarta.xml.bind.JAXBContextFactory from properties passed to provider, as they are required to throw if they find an unsupported property. This was already done for the other find overload.
m0mus
requested changes
Apr 25, 2025
m0mus
left a comment
m0mus
left a comment
There was a problem hiding this comment.
Please update copyright years in all files you changed. I'll approve your PR when its done.
Contributor
Author
|
No problem, I updated the copyright years. |
m0mus
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316
Remove
jakarta.xml.bind.JAXBContextFactoryfrom properties passed to provider, as they are required to throw if they find an unsupported property. This was already done for the other find overload.I also added a 2 test cases to the existing tests for
jakarta.xml.bind.JAXBContextFactorypassed in the properties map.