Merged
Conversation
Contributor
Author
jakobhellermann
approved these changes
Mar 6, 2021
Owner
jakobhellermann
left a comment
There was a problem hiding this comment.
Thank you very much. I've suggested a few minor tweaks, but otherwise this is good to merge.
Contributor
Author
Contributor
Author
|
Note the minor layout issues with the text flowing outside the nodes. I found this issue rust-lang/rust#76500 . If I understand correctly the graphviz engine doesn't have Roboto so is failing to set the width correctly in the SVG, which is then rendered like this (by GIMP in my case). The proposed solution is listing multiple fonts. |
Owner
|
Thanks! Can you try if |
Contributor
Author
|
Doesn't seem to work. Not sure, but can't find good documentation about it, either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I've added slots to the graph. Your dot code was clean enough that I didn't want to add a dependency for that. But the itertools thing is really useful to have. Take a look and let me know what you think.