You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I am totally out of context for such review, is it necessary to add the whole apple natives write group as reviewers?
I think this is a great topic for the next ANIE @radimcervinka! I don't think it's necessary to add the entire group but I do think the question of who should be added merits some discussion.
@radimcervinka, I don’t recall doing that. Perhaps it’s automatic, but as @JacobHearst mentioned, it’s worth discussing.
One option could be just sharing the PR link on the shared code channels or maybe create an apple natives reviewers group with one dev representing each team.
For shared packages, we should ensure that other teams are aware of the updates and it’s not breaking anyone’s codebase (which isn’t the case for this PR, of course). It would also be interesting to determine who the owners and reviewers of shared packages are. I know that Caribou contributed significantly to Subprocess recently, but it’s not exclusively maintained by us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.