refactor: SoftAssertionsExtension을 활용하여 테스트 코드 리팩토링#25
Merged
Conversation
Owner
janeljs
commented
Mar 31, 2021
janeljs
commented
- assertj v.3.18.0으로 변경
- HttpRequestTest, HttpRequestUtilsTest에 SoftAssertions 적용
- assertj v.3.18.0으로 변경 - HttpRequestTest, HttpRequestUtilsTest에 SoftAssertions 적용
ghost
reviewed
Mar 31, 2021
Comment on lines
+12
to
16
| @ExtendWith(SoftAssertionsExtension.class) | ||
| class HttpRequestUtilsTest { | ||
|
|
||
| @InjectSoftAssertions | ||
| SoftAssertions softly; |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.