Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: cortex stop child process#1841

Merged
nguyenhoangthuan99 merged 8 commits into
devfrom
fix/cortex-stop-child-process
Jan 6, 2025
Merged

fix: cortex stop child process#1841
nguyenhoangthuan99 merged 8 commits into
devfrom
fix/cortex-stop-child-process

Conversation

@nguyenhoangthuan99
Copy link
Copy Markdown
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 commented Jan 2, 2025

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Changes made

This pull request introduces several changes to enhance the functionality and robustness of the ProcessManager and related components in the engine. The most important changes include adding new service dependencies to ProcessManager, handling model validation in PythonEngine, and improving the handling of file paths in utility functions.

Enhancements to ProcessManager:

Model validation in PythonEngine:

Improved file path handling:

  • engine/utils/curl_utils.cc: Modified the SimpleGetJsonRecursive function to use std::filesystem::path for safer and more consistent file path handling.

Other changes:

  • engine/main.cc: Updated the instantiation of ProcessManager to include the new service dependencies.
  • engine/services/model_service.cc: Simplified the setting of executable permissions by removing platform-specific code and using a unified approach.

@nguyenhoangthuan99 nguyenhoangthuan99 marked this pull request as ready for review January 2, 2025 06:30
@louis-jan louis-jan changed the title Fix/cortex stop child process fix: cortex stop child process Jan 3, 2025
Comment thread engine/controllers/process_manager.cc Outdated
Comment thread engine/controllers/process_manager.cc Outdated
Comment thread engine/services/model_service.cc Outdated
@nguyenhoangthuan99 nguyenhoangthuan99 merged commit c4b370f into dev Jan 6, 2025
@nguyenhoangthuan99 nguyenhoangthuan99 deleted the fix/cortex-stop-child-process branch January 6, 2025 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants