Skip to content

fix: throws/reject typings#7

Merged
thetutlage merged 2 commits into
4.xfrom
fix/some-strict-typings
Dec 11, 2025
Merged

fix: throws/reject typings#7
thetutlage merged 2 commits into
4.xfrom
fix/some-strict-typings

Conversation

@Julien-R44

Copy link
Copy Markdown
Member

those typings were way too strict
before the PR, TS complained about this :

// TS complains because the function doesnt return `void`
await assert.rejects(() => myFunctionReturningAString())

// TS complains when using an Error constructor that accepts args other than raw Error,
// like the one from poppins/exceptions
await assert.rejects(() => something(), E_MY_ERROR)

@thetutlage thetutlage merged commit bf203dd into 4.x Dec 11, 2025
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants