[1.12.2] Fix sidedness issues with TC & HWYLA integration#1226
Open
jchung01 wants to merge 1 commit intojaquadro:1.12from
Open
[1.12.2] Fix sidedness issues with TC & HWYLA integration#1226jchung01 wants to merge 1 commit intojaquadro:1.12from
jchung01 wants to merge 1 commit intojaquadro:1.12from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes client-only classes being class-loaded on a dedicated server. Functionally, there is no difference as the two integration modules are technically only handled client-side, but now the modules don't error when being registered on the dedicated server.
Thaumcraft error:
HWYLA/Waila error:
Removes reflection usage, as it is not needed to access
ConfigHandler.Discovered in CleanroomMC/Cleanroom#349, as there are visible errors that arise from the bug in a Cleanroom environment.