Fix stats overcounting on key updates in set/mset methods#1531
Closed
Copilot wants to merge 11 commits into
Closed
Fix stats overcounting on key updates in set/mset methods#1531Copilot wants to merge 11 commits into
Copilot wants to merge 11 commits into
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 tasks
Base automatically changed from
node-cache---feat-(breaking)-moving-to-Keyv-as-the-storage
to
main
January 5, 2026 22:27
Co-authored-by: jaredwray <1205481+jaredwray@users.noreply.github.com>
Co-authored-by: jaredwray <1205481+jaredwray@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on moving to Keyv as storage
Fix stats overcounting on key updates in set/mset methods
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setandmsetmethods unconditionally incremented the stats count, causing overcounting when updating existing keys instead of creating new ones.Changes
setmethod: Check key existence viakeyv.has()before incrementing countmsetmethod: Batch check keys viakeyv.hasMany()and increment count only for new keystakemethod: Fix incorrect method names (recordHit/recordMiss→incrementHits/incrementMisses)Example
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.