Skip to content

[WIP] 1.12.0#4381

Merged
lydell merged 18 commits into
jashkenas:masterfrom
GeoffreyBooth:1.12
Dec 4, 2016
Merged

[WIP] 1.12.0#4381
lydell merged 18 commits into
jashkenas:masterfrom
GeoffreyBooth:1.12

Conversation

@GeoffreyBooth

Copy link
Copy Markdown
Collaborator

@jashkenas @lydell I think we’re ready for 1.12.0.

Besides the updated lib folder, browser compiler, docs, annotated source and change log, I snuck in a few more documentation improvements:

  • Docs examples with quotation marks are fixed. (Try running tim.age + " " + tim.height on the current http://coffeescript.org.) Now Cakefile properly escapes the quotes.
  • Eligible HTML entities (basically, anything other than &, < or >) are now written as unicode characters, a recommended practice.
  • Along those lines, quotation marks in regular text are now curly. Ellipses when used as text and not as splat code are now ellipses characters.
  • A link to the browser tests (test.html) was added under Resources.

<div class="pilwrap ">
<a class="pilcrow" href="#section-5">&#182;</a>
</div>
<p>The contents of a <script> block are encoded via UTF-16, so if any extended

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't <script> use escaped <> here?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess docco lets html fall through...

@GeoffreyBooth GeoffreyBooth Dec 2, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping the HTML in backticks fixes this. Once #4383 is merged in, I’ll regenerate the compiler and annotated source.

@greghuc

greghuc commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

@GeoffreyBooth I believe 1.12.0 will be affected by the just-reported 'unescaped backticks in interpolated strings' bug, though only if someone uses tagged template literals. I'll have a fix in the next few days.

Comment thread docs/v1/index.html Outdated
<li>
CoffeeScript’s <a href="#objects_and_arrays">shorthand object
notation</a> is finally documented.
</li>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, all the documentation or build system improvement points (such as this one) are just noise in the change log. It’s really awesome work, but not needed to be in the change log. Again, that’s my opinion. :)

@lydell

lydell commented Dec 1, 2016

Copy link
Copy Markdown
Collaborator

I agree that the 'unescaped backticks in interpolated strings' bug has to be fixed before a release.

@GeoffreyBooth GeoffreyBooth changed the title 1.12.0 [WIP] 1.12.0 Dec 2, 2016
@GeoffreyBooth

Copy link
Copy Markdown
Collaborator Author

Updated with #4383. How about now?

@lydell

lydell commented Dec 4, 2016

Copy link
Copy Markdown
Collaborator

Everything looks good to me! 👍 Nice work.

@GeoffreyBooth

Copy link
Copy Markdown
Collaborator Author

Thanks. I don't have access to NPM. @lydell, can you deploy to there and then accept this PR?

@lydell
lydell merged commit fb0639f into jashkenas:master Dec 4, 2016
@lydell
lydell deleted the 1.12 branch December 4, 2016 19:32
@lydell

lydell commented Dec 4, 2016

Copy link
Copy Markdown
Collaborator

Done.

@greghuc

greghuc commented Dec 4, 2016

Copy link
Copy Markdown
Contributor

@GeoffreyBooth and everyone else involved - congrats on getting 1.12 out. Looking forward to Coffeescript 2 :-)

@GeoffreyBooth

Copy link
Copy Markdown
Collaborator Author

Thanks!

EsrefDurna added a commit to EsrefDurna/coffeescript that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants