[CS2] Fix object spread nested properties#4611
Merged
GeoffreyBooth merged 2 commits intoJul 23, 2017
Merged
Conversation
GeoffreyBooth
changed the title
Collaborator
Author
|
@connec were you able to check this PR? |
Collaborator
|
This still breaks if accesses are mixed with indices 😢 [stdin]:1:18: error: unexpected .
obj2 = { obj["a"].b... }
^ |
Collaborator
Author
|
@connec are you sure? It's working for me. |
connec
approved these changes
Jul 22, 2017
connec
left a comment
connec
left a comment
Collaborator
There was a problem hiding this comment.
I probably checked out the wrong branch 😓 thanks for adding the tests though!
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GeoffreyBooth I noticed an error with the object spread nested properties in branch
2, e.g.obj2 = {obj.a.b.c..., obj["a"]["b"]...}This has been already fixed in #4493, but it seems that something went off in the latest commits.
This small PR restores the functionality back.
@connec do you mind taking a look since your commits also include changes in the
grammar?