Skip to content

fix: greeting widget emojis render consistently (closes #214)#244

Merged
jaylfc merged 1 commit into
masterfrom
fix/greeting-emojis
Apr 20, 2026
Merged

fix: greeting widget emojis render consistently (closes #214)#244
jaylfc merged 1 commit into
masterfrom
fix/greeting-emojis

Conversation

@jaylfc
Copy link
Copy Markdown
Owner

@jaylfc jaylfc commented Apr 20, 2026

Replace afternoon 🌤 (no VS16) and evening 🌅 which rendered as tofu squares on systems without full emoji font coverage. New glyphs (partly cloudy) and 🌆 (dusk cityscape) have broader platform support and match the weather-icon style.

Closes #214.

Summary by CodeRabbit

  • Bug Fixes

    • Improved formatting in "Copy all logs" feature with enhanced line spacing.
  • Style

    • Updated time-of-day greeting emoji displays for afternoon and evening periods.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f3a27d32-36a6-4a35-9fde-a737f7a42f07

📥 Commits

Reviewing files that changed from the base of the PR and between 122491c and eb32a95.

📒 Files selected for processing (6)
  • desktop/src/components/widgets/GreetingWidget.tsx
  • static/desktop/assets/MCPApp-TOkVUCYB.js
  • static/desktop/assets/ProvidersApp-B8CbY8Vv.js
  • static/desktop/assets/SettingsApp-C8E03kzV.js
  • static/desktop/assets/main-C9IShHdB.js
  • static/desktop/index.html

📝 Walkthrough

Walkthrough

Updates emoji mappings in the greeting component to fix broken character rendering and refreshes bundled JavaScript assets with updated module import paths.

Changes

Cohort / File(s) Summary
Greeting UI Updates
desktop/src/components/widgets/GreetingWidget.tsx
Changed emoji mappings: afternoon range (12–17) from 🌤 to ⛅, and evening range (17–21) from 🌅 to 🌆.
Bundle Asset Updates
static/desktop/assets/MCPApp-*.js, static/desktop/assets/ProvidersApp-*.js, static/desktop/assets/SettingsApp-*.js
Updated main module import references from ./main-D_Gu3kUS.js to ./main-C9IShHdB.js. MCPApp bundle also adjusted clipboard log join separator to include extra space after newline.
HTML Entry Point
static/desktop/index.html
Updated desktop module script reference from /desktop/assets/main-D_Gu3kUS.js to /desktop/assets/main-C9IShHdB.js.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A bunny hops through emoji clouds,
Swapping suns for skies so bright!
Bundles dance with imports proud,
All the hash paths now just right. ⛅🌆

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/greeting-emojis

Comment @coderabbitai help to get the list of available commands and usage tips.

…on, 🌆 evening)

Previous afternoon (🌤 without VS16) and evening (🌅) rendered as tofu squares
on systems without full emoji font coverage. Closes #214.
@jaylfc jaylfc force-pushed the fix/greeting-emojis branch from bdb02df to eb32a95 Compare April 20, 2026 15:46
@jaylfc jaylfc merged commit 0aea293 into master Apr 20, 2026
6 of 7 checks passed
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Apr 20, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • desktop/src/components/widgets/GreetingWidget.tsx
  • static/desktop/assets/MCPApp-TOkVUCYB.js (generated asset rename - skipped review)

Reviewed by seed-2-0-pro-260328 · 145,452 tokens

Copy link
Copy Markdown

@kilo-code-bot kilo-code-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. Approved.

@jaylfc jaylfc deleted the fix/greeting-emojis branch April 25, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken sun emoji in 'Good evening' greeting

1 participant