Fixes copy and pasting nodes with accept_connection_types and/or reject_connection_types. #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonassorgenfrei
force-pushed
the
fix-copy-paste-node-with-port-accept
branch
from
8b2c8e6 to
8e1113f
Compare
jonassorgenfrei
force-pushed
the
fix-copy-paste-node-with-port-accept
branch
3 times, most recently
from
d8fd107 to
1868e8a
Compare
…ct_connection_types. Closes jchanvfx#464 removed optimization flag. Update viewer.py fixed the drop event error QPoint(): too many arguments QPoint(xpos: int, ypos: int): argument 1 has unexpected type 'float' QPoint(a0: QPoint): argument 1 has unexpected type 'float' Update base_node.py i have added NodeButton Update node_widgets.py Added NodeButton version bump update example with vertical aligned node graph expose option to paste nodes without overwriting the style of the graph
jonassorgenfrei
force-pushed
the
fix-copy-paste-node-with-port-accept
branch
from
5b9d734 to
8d26720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is the serialization and deserialization of nodes that have accept_connection_types and/or reject_connection_types.
This is a 4 times nested dict:
The current implementation is only taking the first two levels into account during the serializing and deserializing phase.
Closes #464