Remove RestContext from Rackspace examples#35
Conversation
|
Did you run the SmokeTest with these changes? When that passes, I'm a +1. |
|
Yes! I ran SmokeTest against the code that was changed and everything passes. |
|
Merged. Thanks! |
There was a problem hiding this comment.
Hm...do we recommend building two separate things here? Isn't that effectively creating two contexts, which is quite expensive? In this case, I'd say the old approach (building one context, then getting the compute service and unwrapping the context) is preferable?
|
Most of the cleanup is great, thanks @jdaggett! Just a comment about those examples where we use both the ComputeService view and the API. This refactoring now ends up creating two contexts in those cases, which I'm not sure is a good thing to be recommending? @everett-toews @zack-shoylev What do you think..? |
|
@demobox Thanks for the feedback! Removal of RestContext was the first step in a bunch of example changes coming. I can update with your suggestions in the next PR which is underway now. WDYT? |
Works for me! Would just be curious to see what we feel collectively about creating two contexts vs. using |
|
Didn't notice that when going through the PR. and agree. Examples should be creating only one context! |
Sounds good! Thanks, @jdaggett! |
This PR removes RestContext from the Rackspace examples as the first step towards the work to be done in JCLOUDS-346.
Please refer to JCLOUDS-152 which discusses the removal of RestContext.
Each updated example was debugged/tested against the Rackspace Cloud IAD region.
The logo link has also been updated post site-branding... Thx!