Skip to content

Typescript Support#183

Merged
jdalrymple merged 38 commits into
masterfrom
next
Sep 5, 2018
Merged

Typescript Support#183
jdalrymple merged 38 commits into
masterfrom
next

Conversation

@jdalrymple

Copy link
Copy Markdown
Owner

No description provided.

pablobirukov and others added 30 commits August 16, 2018 10:23
* change target for modern env from es2017 to es6 (async/await should be transpiled to downlevel js)
* import correct 'wait' fn
* export 'wait'
* fix src/services/Projects.ts (likely was broken after wrong conflict resolution)
* fix next branch linting and renaming files
* Add git semantic release dep
…de the inherited members. #141" until properly implemented by GitLab (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6669)

This reverts commit e081a16.

Adding project archive abilities
@jdalrymple jdalrymple changed the title Next Typescript Support Sep 4, 2018
@jetersen

jetersen commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

A few conflicts that need to be resolved 😅

@jdalrymple

Copy link
Copy Markdown
Owner Author

@Casz 😂 yea, ill get to those today

@jetersen

jetersen commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Just being captain obvious 😂

@jetersen

jetersen commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Seems this was merged in: 31132ce

@jdalrymple

Copy link
Copy Markdown
Owner Author

Just realized i merged this incorrectly, fixing that now

@jetersen

jetersen commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

🥇

@jdalrymple jdalrymple merged commit 6d5a4b9 into master Sep 5, 2018
@jdalrymple jdalrymple deleted the next branch September 5, 2018 15:31
jdalrymple added a commit that referenced this pull request Sep 5, 2018
chore(package): Updating typescript  3.0.1  →  3.0.3
chore(package): Updating @semantic-release/git   ^7.0.1  →    ^7.0.3
chore(package): Updating @semantic-release/npm   ^5.0.2  →    ^5.0.4
chore(package): Updating semantic-release       ^15.9.8  →  ^15.9.12
chore(package): Updating codecov                 ^3.0.4  →    ^3.1.0
chore(package): Updating ts-jest                ^23.1.3  →   ^23.1.4
chore(package): Updating tslint-config-airbnb    ^5.9.2  →   ^5.11.0
jdalrymple pushed a commit that referenced this pull request Sep 5, 2018
## [3.11.4](3.11.3...3.11.4) (2018-09-05)

### Performance Improvements

* Conversion to Typescript ([#183](#183)) ([ce0c1fe](ce0c1fe))
@jdalrymple

Copy link
Copy Markdown
Owner Author

🎉 This PR is included in version 3.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@josh64x2

josh64x2 commented Sep 6, 2018

Copy link
Copy Markdown

@jdalrymple It looks like the typings aren't included in the dist? "declaration": true needs to be set in the tsconfig.dist.json and then the types key should be set in package.json. It would be great to use this library from within other typescript projects.

EDIT: I guess what I'm trying to say is, was it intentional to not include the typings? Or should I create a PR with these changes? :)

@jetersen

jetersen commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

@josh64x2 #137 (comment)

@josh64x2

josh64x2 commented Sep 6, 2018

Copy link
Copy Markdown

@Casz ahhh thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants