Added user snippets API support#189
Conversation
|
I don't know how i missed that lol. In your PR you have a content function pointing to a raw endpoint, but i dont see that endpoint in the docs? Also you could probably combine all and allPublic and add public as an optional param like: ...
all(options = { public: false }) {
const { public, ...opts } = options
const url = public ? 'snippets/public' : 'snippets';
return RequestHelper.get(this, url, opts);
}To cut down on the amount of functions. |
|
The I combined |
|
Looks good!! Just a couple things left!
|
|
Fixed the lint error. I don't know if it should be added to the user bundle. There is no It's up to you. If you really want it I can add it. |
|
That makes sense. We'll leave it out. |
|
Alright then. Should I add some tests to fix that codecov check? |
|
If you have some time that would be amazing! |
* chore(package): Update jest-extended to the latest version 🚀 0.9.0 (#191) * chore(package): update lockfile package-lock.json * feat: Re-add list all project members endpoint (#190, #141) * feat: Adding markdown support #182 (#193) * fixes: #188: `stream` option is lost in any `get` request that is streamable (#192) * feat: Added user snippets API support (#189) * chore(test): Added test for creating snippets * feat: Added user edit support #186
* chore(package): Update jest-extended to the latest version 🚀 0.9.0 (#191) * chore(package): update lockfile package-lock.json * feat: Re-add list all project members endpoint (#190, #141) * feat: Adding markdown support #182 (#193) * fixes: #188: `stream` option is lost in any `get` request that is streamable (#192) * feat: Added user snippets API support (#189) * chore(test): Added test for creating snippets * feat: Added user edit support #186
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
User snippets do not belong to a specific project and have a different API resource than the project snippets.