Skip to content

Revert "feat: 日历组件无障碍"#3438

Merged
xiaoyatong merged 1 commit into
feat_v3.xfrom
revert-3437-feat_v3.x
Apr 26, 2026
Merged

Revert "feat: 日历组件无障碍"#3438
xiaoyatong merged 1 commit into
feat_v3.xfrom
revert-3437-feat_v3.x

Conversation

@xiaoyatong

@xiaoyatong xiaoyatong commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Reverts #3437

Summary by CodeRabbit

重构

  • CalendarCard 组件移除了 weekdays 属性支持,不再允许自定义周日期标签
  • 精简了日期相关的无障碍标签逻辑
  • 优化了周日期标题的计算机制
  • 移除了相关演示代码及多语言配置

@github-actions github-actions Bot added action:review This PR needs more reviews (less than 2 approvals) 3.x Target branch 3.x labels Apr 26, 2026
@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

概览

本 PR 从 CalendarCard 组件及其 TypeScript 定义中移除了 weekdays 属性,删除了展示自定义工作日标签的演示组件,移除了日期元素上的可访问性标记逻辑,并将工作日标题的响应式计算替换为基于 locale 和 firstDayOfWeek 的单次初始化。

变更内容

组件/文件 摘要
CalendarCard 组件
src/packages/calendarcard/calendarcard.taro.tsx
移除 weekdays 属性及其默认值,删除基于日期的可访问性标记逻辑(isToday/getAriaLabel),移除日期元素上的 ariaLabelariaRoleariaHidden 属性,将工作日标题计算从 useMemo 改为 useState 初始化器。
文档与演示
src/packages/calendarcard/demo.taro.tsx, src/packages/calendarcard/demos/taro/demo13.tsx
删除 Demo13 组件导入和渲染,移除 zh-CNzh-TWen-US 中的 customWeekdays 翻译键,删除展示自定义工作日功能的 UI 部分。
类型定义
src/types/spec/calendarcard/base.ts
BaseCalendarCard 接口中移除可选的 weekdays?: string[] 属性。

评估代码审查难度

🎯 3 (中等) | ⏱️ ~20 分钟

可能相关的 PR

  • PR #3437: 该 PR 同样修改了 CalendarCard 的属性和日期元素的可访问性逻辑,此次 PR 移除了之前添加的 weekdays 属性和 ARIA 标记。
  • PR #3285: 两个 PR 都修改了 CalendarCard 组件和 BaseCalendarCard 属性(一个移除 weekdays 属性,另一个添加 title 属性),涉及同一组件/接口。

建议审查人员

  • oasis-cloud
  • Miles-hxy

诗歌

🐰 一跃而去的工作日花名册,

简约化的日历更清新。

无需自定义的繁复,

本地化足矣,轻松又从容!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR描述未按照仓库要求的模板填写,缺少问题性质、背景说明和自查清单等必要信息。 请根据仓库模板完善描述,包括变动性质复选框、相关Issue、需求背景和自查清单。
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 标题清晰准确地描述了主要变化——撤销了之前的无障碍功能提交(PR #3437)。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-3437-feat_v3.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xiaoyatong
xiaoyatong merged commit e8e64ea into feat_v3.x Apr 26, 2026
5 of 6 checks passed
@xiaoyatong
xiaoyatong deleted the revert-3437-feat_v3.x branch April 26, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant