Extend debug message logging / debug output - #37
Closed
fonic wants to merge 1 commit into
Closed
Conversation
This was referenced May 4, 2018
Closed
fonic
changed the title
Extend debug message logging / debug output: - add support for message types (debug, info, warning, error) - introduce logging macros to easily log messages (debugf, infof, warnf, errorf) - log messages to user-defined callback instead of file so that application may be decide how to handle debug output - add string conversion functions that may be used in printf-style function calls (address family, IP protocol version, bucket/node ID, socket address, etc.) - add DHT_LOG_ defines to control certain features - add function to retrieve statistics (buckets, good nodes, dubious nodes, total nodes) - modify dump_bucket() and dht_dump_tables() to output tables - migrate all debugf calls to make use of the new capabilities - add additional debug output - modify dht-example to make use of the new capabilities
Owner
|
Rejected. We don't need this complexity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends debug message logging / debug output generated by the library.
Additions/changes:
debugf,infof,warnf,errorf)debugfcalls todebugf,infof,warnfanderrorfcallsdht_stats()to retrieve current statistics (number of buckets, good/dubious/total nodes)dht-exampleto demonstrate the new capabilities by generating colorful log output and printing statistics when dumping/exitingNOTE:
There are certain limitations regarding the string conversion functions:
These limitations are the result of using static buffers to return the strings. Since all of this is only about debug output, I figured one can live with the limitations.
Screenshot:
