Add "Checks" permissions to github-app docs#734
Closed
arogge wants to merge 1 commit into
Closed
Conversation
the documented permissions were incomplete. To make the plugin actually work, you have to also enable Read/Write permissions on Checks.
Member
Well, technically this plugin does not do anything with Checks, only commit statuses. But you would likely want to combine it with |
Member
|
Best to make that explicit, and also update https://plugins.jenkins.io/github-checks/#plugin-content-features correspondingly. |
Member
|
see #746 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the documented permissions were incomplete. To make the plugin actually work, you have to also enable Read/Write permissions on Checks.
Submitter checklist
Link to JIRA ticket in description, if appropriate.Change is code complete and matches issue descriptionAutomated tests have been added to exercise the changesReviewer's manual test instructions provided in PR description. See Reviewer's first task below.Reviewer checklist
Documentation changes
Users/aliases to notify