Skip to content

[JENKINS-73388] Allow alternative implementation for GitHub App credentials#794

Closed
jeromepochat wants to merge 2 commits into
jenkinsci:masterfrom
jeromepochat:JENKINS-73388
Closed

[JENKINS-73388] Allow alternative implementation for GitHub App credentials#794
jeromepochat wants to merge 2 commits into
jenkinsci:masterfrom
jeromepochat:JENKINS-73388

Conversation

@jeromepochat
Copy link
Copy Markdown
Contributor

@jeromepochat jeromepochat commented Jul 2, 2024

The current Connector supports GitHub App credentials with class inheritance constraint on credentials implementation.

This PR introduces an interface to support GitHub App credentials alternative implementations that cannot extends GitHubAppCredentials.

See JENKINS-73388 for further information.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@jeromepochat jeromepochat requested a review from a team as a code owner July 2, 2024 14:53
@jeromepochat jeromepochat marked this pull request as draft July 2, 2024 15:39
@jeromepochat jeromepochat marked this pull request as ready for review July 2, 2024 16:07
@jeromepochat jeromepochat marked this pull request as draft July 5, 2024 14:56
@jeromepochat
Copy link
Copy Markdown
Contributor Author

Closed as superseded by #796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant