Skip to content

[JENKINS-76056] Clarify inference limitations of GitHub App Credentials new options#888

Merged
jeromepochat merged 4 commits into
jenkinsci:masterfrom
jeromepochat:JENKINS-76056-doc-improvement
Sep 4, 2025
Merged

[JENKINS-76056] Clarify inference limitations of GitHub App Credentials new options#888
jeromepochat merged 4 commits into
jenkinsci:masterfrom
jeromepochat:JENKINS-76056-doc-improvement

Conversation

@jeromepochat
Copy link
Copy Markdown
Contributor

@jeromepochat jeromepochat commented Sep 4, 2025 •
edited
Loading

Description

This aims to clarify the limitations of the GitHub App Credentials new options and add backward compatibility notes.

See JENKINS-76056 for further information.

Note

The release note for 1844.v4a_9883d49126 will be updated with a link to the documentation after merge.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@jeromepochat jeromepochat requested a review from a team as a code owner September 4, 2025 12:03
@jeromepochat jeromepochat changed the title Clarify limitations and backwards compatibility [JENKINS-76056] Clarify limitations and backwards compatibility Sep 4, 2025
@jeromepochat jeromepochat changed the title [JENKINS-76056] Clarify limitations and backwards compatibility [JENKINS-76056] Clarify limitations of GitHub App Credentials new options and backwards compatibility Sep 4, 2025
@jeromepochat jeromepochat changed the title [JENKINS-76056] Clarify limitations of GitHub App Credentials new options and backwards compatibility [JENKINS-76056] Clarify inference limitations of GitHub App Credentials new options Sep 4, 2025
dwnusbaum
dwnusbaum reviewed Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, I added a few suggestions

Comment thread docs/github-app.adoc Outdated
Comment thread docs/github-app.adoc Outdated
Comment thread docs/github-app.adoc Outdated
jeromepochat and others added 3 commits September 4, 2025 16:32
@jeromepochat @dwnusbaum
Update docs/github-app.adoc
e7f6a6a 
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
@jeromepochat @dwnusbaum
Update docs/github-app.adoc
1bfe753 
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
@jeromepochat @dwnusbaum
Update docs/github-app.adoc
ae4b2d3 
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
@jeromepochat jeromepochat merged commit e66cbb9 into jenkinsci:master Sep 4, 2025
17 checks passed
@jeromepochat jeromepochat deleted the JENKINS-76056-doc-improvement branch September 4, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeromepochat @dwnusbaum