Skip to content

docs: correct required app permissions in setup description#321

Merged
timja merged 1 commit into
jenkinsci:masterfrom
CCFenner:patch-1
Mar 24, 2023
Merged

docs: correct required app permissions in setup description#321
timja merged 1 commit into
jenkinsci:masterfrom
CCFenner:patch-1

Conversation

@CCFenner
Copy link
Copy Markdown
Contributor

The linked guide to setup GH apps for authentication is missing the checks permission. Without that the plugin is not able to report back to GH. This changes explicitly states this in the setup description.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@CCFenner CCFenner requested a review from a team as a code owner March 24, 2023 11:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2023

Codecov Report

Merging #321 (5b85029) into master (a51e30c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #321   +/-   ##
=========================================
  Coverage     80.79%   80.79%           
  Complexity      170      170           
=========================================
  Files            16       16           
  Lines           526      526           
  Branches         49       49           
=========================================
  Hits            425      425           
  Misses           79       79           
  Partials         22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timja timja merged commit a123bba into jenkinsci:master Mar 24, 2023
@jglick
Copy link
Copy Markdown
Member

jglick commented Nov 15, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants