Skip to content

[#393] Re-enable skipped conclusion#394

Merged
timja merged 1 commit into
jenkinsci:masterfrom
beikov:patch-1
Jul 16, 2024
Merged

[#393] Re-enable skipped conclusion#394
timja merged 1 commit into
jenkinsci:masterfrom
beikov:patch-1

Conversation

@beikov
Copy link
Copy Markdown
Contributor

@beikov beikov commented Jul 16, 2024

Fixed #393.

Testing done

Tested creating a check run with the SKIPPED conclusion which just works: https://github.com/beikov/hibernate-github-bot-test/runs/27508834193

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@beikov beikov requested a review from a team as a code owner July 16, 2024 13:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (803edab) to head (762f466).
Report is 13 commits behind head on master.

Files Patch % Lines
...ins/plugins/checks/github/GitHubChecksDetails.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #394      +/-   ##
============================================
- Coverage     71.80%   71.66%   -0.14%     
  Complexity      162      162              
============================================
  Files            16       16              
  Lines           532      533       +1     
  Branches         51       51              
============================================
  Hits            382      382              
- Misses          124      125       +1     
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timja timja added the enhancement New feature or request label Jul 16, 2024
@timja timja merged commit a9669c9 into jenkinsci:master Jul 16, 2024
@beikov beikov deleted the patch-1 branch July 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable skipped conclusion

2 participants