Skip to content

Ban JUnit 4 imports#463

Merged
timja merged 1 commit into
jenkinsci:masterfrom
strangelookingnerd:patch-1
Aug 15, 2025
Merged

Ban JUnit 4 imports#463
timja merged 1 commit into
jenkinsci:masterfrom
strangelookingnerd:patch-1

Conversation

@strangelookingnerd
Copy link
Copy Markdown
Contributor

Ban JUnit 4 imports

To prevent regressions when adding new tests, jenkinsci/plugin-pom#1178 introduced a new flag that enables a Maven Enforcer rule banning org.junit.* imports while allowing org.junit.jupiter.*.

With this change, the build will fail if any org.junit.* imports are introduced.

Testing done

None. Rely on ci.jenkins.io.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner August 15, 2025 13:04
@timja timja added the chore label Aug 15, 2025
@timja timja enabled auto-merge (squash) August 15, 2025 13:11
@timja timja merged commit 15fae2e into jenkinsci:master Aug 15, 2025
17 of 18 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.99%. Comparing base (803edab) to head (c1a339f).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #463      +/-   ##
============================================
+ Coverage     71.80%   71.99%   +0.18%     
- Complexity      162      163       +1     
============================================
  Files            16       16              
  Lines           532      532              
  Branches         51       51              
============================================
+ Hits            382      383       +1     
+ Misses          124      123       -1     
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants