GitHubAppCredentials does not host owner anymore#468
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
=========================================
Coverage 71.80% 71.80%
Complexity 162 162
=========================================
Files 16 16
Lines 532 532
Branches 51 51
=========================================
Hits 382 382
Misses 124 124
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timja
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Branch Source 1844.v4a_9883d49126 provides new options to restrict the repositories and permissions available to installation access tokens. This brings some backwards compatibility limitations.
By default,
GitHubAppCredentialsappliesAccessInferredOwnerstrategy.When trying to bump
github-branch-source,GitHubChecksPublisherITestis failing because the owner cannot infer owner as the GitHub App installation are returning a single owner namedboguswhile repositories owner isXiongKezhi:I assume that WireMock resources were designed with
XiongKezhi/bogusmismatch to checkownerupdate fromGitHubAppCredentials.As
GitHubAppCredentialsdoes not hostowneranymore, this fixesGitHubChecksPublisherITestwith:AccessInferredOwnerstrategyownercheck from testXiongKezhiuser onlyTesting done
mvn testpasses locally.Submitter checklist