Skip to content

Respect quiet period when triggering builds#519

Merged
timja merged 1 commit into
jenkinsci:masterfrom
jangalda-nsc:bugfix/respect-quiet-period
Mar 24, 2026
Merged

Respect quiet period when triggering builds#519
timja merged 1 commit into
jenkinsci:masterfrom
jangalda-nsc:bugfix/respect-quiet-period

Conversation

@jangalda-nsc
Copy link
Copy Markdown
Contributor

Fixes an issue where builds are triggered immediately on CHECK_RUN events. Previously, ignoring the quiet period could cause multiple builds to run in parallel.

According to ParameterizedJobMixIn.scheduleBuild2 docstring:

quietPeriod – seconds to wait before starting; use -1 to use the job’s default settings

Testing done

  • Automated test suite executed locally

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Fixes an issue where builds are triggered immediately on CHECK_RUN events.
Previously, ignoring the quiet period could cause multiple builds to run in parallel.
@jangalda-nsc jangalda-nsc requested a review from a team as a code owner March 19, 2026 10:36
@timja
Copy link
Copy Markdown
Member

timja commented Mar 19, 2026

Testing done
Automated test suite executed locally

Can you run this in your instance and verify it solves the issue please?

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.64%. Comparing base (803edab) to head (866aef9).
⚠️ Report is 112 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #519      +/-   ##
============================================
- Coverage     71.80%   71.64%   -0.17%     
- Complexity      162      163       +1     
============================================
  Files            16       16              
  Lines           532      536       +4     
  Branches         51       53       +2     
============================================
+ Hits            382      384       +2     
  Misses          124      124              
- Partials         26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jangalda-nsc
Copy link
Copy Markdown
Contributor Author

I've tested the change on Jenkins instance, and it works - build was triggered after quiet period

@jangalda-nsc
Copy link
Copy Markdown
Contributor Author

@timja could you please check this PR?

@timja timja added the enhancement New feature or request label Mar 24, 2026
@timja timja merged commit 74133da into jenkinsci:master Mar 24, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants