General cleanup to improve code quality#61
Merged
Conversation
* Bump parent pom for findbugs rules * Fix findbugs violations * Pruned unneeded dependencies * Upgraded dependencies * Fixed serialization of authentication token + added test
Merged
Member
|
Thanks for the contribution. I'll look it over. |
thatsmydoing
added a commit
to thatsmydoing/github-oauth-plugin
that referenced
this pull request
Jun 25, 2025
In jenkinsci#61, use of `gh` was replaced by `getGitHub()` but the check for `gh != null` was not removed. `getGitHub()` already ensures that it's present so there's no need to do the check. The check was causing calls to `loadUser`, etc to return `null` if a token was restored and nothing that transitively calls `getGitHub()` has been called yet. In particular, when a user logs in, their authorities will be empty because GithubSecurityRealm tries to `loadUser` in `loadUserByUsername2` and sets authorities to empty if the user is `null`. Only later, when something transitively calls `getGitHub()`, will the user have the authorities set.
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @samrocketman