[FIX JENKINS-50288] Add new option "cancelProcessOnExternalsFail" for ModuleLocation#204
Merged
Merged
Conversation
…ch determines if the process should be cancelled when checkout/update svn:externals failed. Sometimes, when svn:externals checkout/update failed, the artifacts generated is likely to fall short of expectations, but now it's ignored by default and no message can found in the log.
oleg-nenashev
approved these changes
Feb 19, 2018
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
The code LGTM though there are some formatting changes
| @@ -0,0 +1,3 @@ | |||
| <div> | |||
| Determines if the process should be cancelled when checkout/update svn:externals failed. Will work when "Ignore externals" box is not checked. | |||
Member
There was a problem hiding this comment.
Maybe it needs to be clarified to explicitly say that the default behavior is to fail the checkout
Contributor
Author
There was a problem hiding this comment.
Sorry for ignoring the code formatting while my IDE using different style, already correct it, and default behavior is clarified too.
Member
…ancelProcessOnExternalsFail" option
oleg-nenashev
approved these changes
Mar 4, 2018
Contributor
Author
|
@oleg-nenashev @kuisathaverat Thank you for your approval! Is there any other work I need to supplement? Can these commits be merged for now? ^_^ |
Member
|
I think it just needs some time before we integrate everything & cut the release. ETA: this week |
kuisathaverat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which determines if the process should be cancelled when checkout/update svn:externals failed.
Sometimes, when svn:externals checkout/update failed, the artifacts generated is likely to fall short of expectations, but now it's ignored by default and no message can found in the log.