build: Install static lib by rzr · Pull Request #1948 · jerryscript-project/iotjs

rzr · 2020-07-24T20:22:55Z

This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: https://github.com/jerryscript-project/iotjs/pull/rzr
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: #1945
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Update: 2020-07-24 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

dbatyai · 2020-07-27T13:39:40Z

  ${EXTERNAL_LIBS}
 )
-
+target_link_libraries(${TARGET_STATIC_IOTJS}


This isn't necessary, the library will already be linked by the previous link_libraries call, since TARGET_LIB_IOTJS and TARGET_STATIC_IOTJS are just an alias for the same libiotjs target.

ok, I just verified

dbatyai · 2020-07-27T13:39:56Z

 # Configure the libiotjs
 set(TARGET_LIB_IOTJS libiotjs)
+# Configure the libiotjs.a
+set(TARGET_STATIC_IOTJS libiotjs)


I don't tnink it's necessary to add another alias.

it's not anymore

dbatyai · 2020-07-27T13:45:11Z

          RUNTIME DESTINATION "${INSTALL_PREFIX}/bin"
          LIBRARY DESTINATION "${INSTALL_PREFIX}/lib"
          PUBLIC_HEADER DESTINATION "${INSTALL_PREFIX}/include/iotjs")
+  install(TARGETS ${TARGET_LIB_IOTJS} DESTINATION ${LIB_INSTALL_DIR}) 


The install command can take multiple target arguments, I'd suggest to not duplicate the calls. The install call on line 588 could be modified to be install(TARGETS ${TARGET_IOTJS} ${TARGET_LIB_IOTJS} ..., and then the calls on line 592 and 594 could be removed.

yes you're right, I am updating my patch and will update the other one that use destdir

This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Update: 2020-07-24 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896). Also remove headers, lib when installing executable. This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package The extra archive rule is needed to prevent this error: install TARGETS given no ARCHIVE DESTINATION for static library target Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

rzr · 2020-10-16T10:54:29Z

review welcome

cc: @galpeter

rzr · 2020-10-21T02:09:07Z

This change is released in:
https://tracker.debian.org/news/1184873/accepted-iotjs-10715-1-source-into-unstable/

rzr · 2020-12-09T11:19:24Z

Please review

meanwhile this change is in debian's testing branch:

https://tracker.debian.org/pkg/iotjs

[2020-10-26] iotjs 1.0+715-1 MIGRATED to testing (Debian testing watch)

cc: @akosthekiss, @dbatyai, @zherczeg

akosthekiss

LGTM in general but may be blocking on #1923

rzr · 2020-12-21T12:37:19Z

Thanks @akosthekiss ,

I will rebase
#1923
once
#1948
is merged

rzr · 2021-04-13T13:37:28Z

hi, can this be merged? FYI next debian release might feature this change

cc: @zherczeg @galpeter

rzr · 2021-05-11T11:42:34Z

Hi I plan to update iotjs in Debian,
It would help to have this change in, then I'll make a snapshot release.

On #1948 (review)
@akosthekiss said "LGTM"

I need 2 approvals to merge it, it's only a few lines to review:

b13fa73

zherczeg

LGTM

rzr · 2021-05-12T07:46:07Z

Thanks @zherczeg

Anyone for an other approval please ?

Cc: @LaszloLango , @ILyoan, @hs0225

LaszloLango

LGTM

rzr force-pushed the sandbox/rzr/cmake/lib/review/master branch from bbadd02 to 6a23d55 Compare July 24, 2020 20:23

dbatyai reviewed Jul 27, 2020

View reviewed changes

rzr force-pushed the sandbox/rzr/cmake/lib/review/master branch from 6a23d55 to 2b7a1cd Compare October 15, 2020 15:56

rzr force-pushed the sandbox/rzr/cmake/lib/review/master branch from 2b7a1cd to 8abaed1 Compare October 15, 2020 15:57

This was referenced Oct 15, 2020

build: Install to system's path (prefixed by destdir) #1923

Merged

build: Install headers #1896

Closed

rzr force-pushed the sandbox/rzr/cmake/lib/review/master branch from 8abaed1 to 1855b93 Compare October 15, 2020 16:23

rzr force-pushed the sandbox/rzr/cmake/lib/review/master branch from 1855b93 to 2e56e9b Compare October 15, 2020 16:41

rzr force-pushed the sandbox/rzr/cmake/lib/review/master branch from 2e56e9b to b13fa73 Compare October 16, 2020 09:18

rzr mentioned this pull request Oct 16, 2020

[WIP]: Update jerryscript submodule to v2.3.0-261-gf6cf1400 from master #1953

Closed

akosthekiss reviewed Dec 21, 2020

View reviewed changes

zherczeg approved these changes May 11, 2021

View reviewed changes

LaszloLango approved these changes May 12, 2021

View reviewed changes

LaszloLango merged commit 403f55b into jerryscript-project:master May 12, 2021

Conversation

rzr commented Jul 24, 2020

Uh oh!

dbatyai Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

rzr Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

dbatyai Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

rzr Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

dbatyai Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

rzr Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

rzr commented Oct 16, 2020

Uh oh!

rzr commented Oct 21, 2020

Uh oh!

rzr commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akosthekiss left a comment

Choose a reason for hiding this comment

Uh oh!

rzr commented Dec 21, 2020

Uh oh!

rzr commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rzr commented May 11, 2021

Uh oh!

zherczeg left a comment

Choose a reason for hiding this comment

Uh oh!

rzr commented May 12, 2021

Uh oh!

LaszloLango left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rzr commented Dec 9, 2020 •

edited

Loading

rzr commented Apr 13, 2021 •

edited

Loading