Skip to content
This repository was archived by the owner on Apr 15, 2020. It is now read-only.

Issue 80 refine table editing controller design#100

Merged
jessesquires merged 7 commits into
developfrom
issue_80_refine_TableEditingController_design
Jan 1, 2018
Merged

Issue 80 refine table editing controller design#100
jessesquires merged 7 commits into
developfrom
issue_80_refine_TableEditingController_design

Conversation

@psartzetakis
Copy link
Copy Markdown
Collaborator

@psartzetakis psartzetakis commented Sep 6, 2017

Pull request checklist

This fixes issue #80

What's in this pull request?

  1. The Item now is passed on the CanEditRow closure.
  2. The dataSource is now passed on the CommitEditingStyleForRow closure.
  3. The user can now pass the tableEditingController closure directly on the initialiser.
  4. Added example for the FetchedResultsController

@psartzetakis
passing the item back to the closure
5f7a372
@psartzetakis
Merge branch 'develop' into issue_80_refine_TableEditingController_de…
112f73b 
…sign
@psartzetakis
initial work
d90369f
@psartzetakis
Merge branch 'TableEditingController_Improvement' into issue_80_refin…
d1e4552 
…e_TableEditingController_design

# Conflicts:
#	Example/Sources/TableViewController.swift
#	Source/DataSourceProvider.swift
#	Source/TableEditingController.swift
#	Tests/DataSourceProviderTests.swift
@psartzetakis
Merge branch 'develop' into issue_80_refine_TableEditingController_de…
4351039 
…sign
@psartzetakis
1. Item is passed on CanEditRow.
f38b779 
2. DataSource is passed on commitRow.
3. Passing the TableEditingController closure from the initialiser.
4. Updated Docs and Tests.
@psartzetakis
tidy up
8a0da0c
psartzetakis
psartzetakis commented Sep 6, 2017
View reviewed changes
Comment thread Source/DataSourceProvider.swift
The same applies to collection views that do not have supplementary views. Again, the parameter will be ignored.
*/
public init(dataSource: DataSource, cellFactory: CellFactory, supplementaryFactory: SupplementaryFactory) {
public init(dataSource: DataSource, cellFactory: CellFactory, supplementaryFactory: SupplementaryFactory, tableEditingController: TableEditingController<DataSource>? = nil) {
Copy link
Copy Markdown
Collaborator Author

@psartzetakis psartzetakis Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current update it is possible for the user to pass the tableEditingController through the initialiser. However I have still left the old implementation with the _tableEditingController for the time being. I was thinking of deprecating the old way (assigning it through the variabletableEditingController) but I wanted your opinion first @jessesquires .

@psartzetakis
Copy link
Copy Markdown
Collaborator Author

psartzetakis commented Sep 6, 2017

Hi @jessesquires ,
Apologies for the delay..😅. I finally managed to submit the PR 😀.

@jessesquires jessesquires added this to the 7.0.0 milestone Nov 6, 2017
@jessesquires
Copy link
Copy Markdown
Owner

jessesquires commented Nov 6, 2017 •
edited
Loading

thanks @psartzetakis ! sorry for the delay 😄

i'll try to get this and #98 merged soon.

i've decided to drop the 6.1.0 milestone in favor of just doing 7.0.0 with Swift 4 and other breaking-changes refactoring 😄

@jessesquires jessesquires merged commit 8a0da0c into develop Jan 1, 2018
@jessesquires jessesquires deleted the issue_80_refine_TableEditingController_design branch January 1, 2018 00:18
@jessesquires jessesquires mentioned this pull request Jan 1, 2018
Closed
jessesquires added a commit that referenced this pull request Jan 1, 2018
@jessesquires
TableEditingController refinements/fixes, follow-up to #100, #80
14d4df0 
- Only allow passing tableEditingController via init
- Restrict init with tableEditingController to extension for tableview-only
- Update changelog, close #82
- Example cleanup, refinements, formatting
@jessesquires
Copy link
Copy Markdown
Owner

jessesquires commented Jan 1, 2018

hey @psartzetakis ! finally merged 🎉

this is great. 😎

I made a couple of minor edits in 14d4df0:

@jessesquires
Copy link
Copy Markdown
Owner

jessesquires commented Jan 1, 2018

I'm hoping to get 7.0 release by Monday, Jan 1. 🎉

also cc @dcaunt 😄

@psartzetakis
Copy link
Copy Markdown
Collaborator Author

psartzetakis commented Jan 2, 2018

Hey @jessesquires , Awesome news 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jessesquires jessesquires Awaiting requested review from jessesquires

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@psartzetakis @jessesquires