Skip to content
This repository was archived by the owner on Apr 15, 2020. It is now read-only.

Add example with mixed cell types#58

Merged
jessesquires merged 2 commits into
jessesquires:developfrom
dcaunt:composed-cell-example
Jul 27, 2016
Merged

Add example with mixed cell types#58
jessesquires merged 2 commits into
jessesquires:developfrom
dcaunt:composed-cell-example

Conversation

@dcaunt
Copy link
Copy Markdown
Collaborator

@dcaunt dcaunt commented Jul 25, 2016

Pull request checklist

This fixes issue #57

What's in this pull request?

An example implementing the approach discussed in #57

Let me know if you'd like to revise the example in any way or if there are any issues.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 25, 2016

Current coverage is 89.04% (diff: 100%)

Merging #58 into develop will not change coverage

@@            develop        #58   diff @@
==========================================
  Files             9          9          
  Lines           365        365          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            325        325          
  Misses           40         40          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 66adb74...1f5798a


@IBOutlet weak var label: UILabel!

var testing = false
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this? 😄

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh haha, will do

@jessesquires
Copy link
Copy Markdown
Owner

Thanks so much @dcaunt ! This is awesome ✨ 🎉

@jessesquires
Copy link
Copy Markdown
Owner

1 small comment. Looks like some left over debugging code?

@jessesquires
Copy link
Copy Markdown
Owner

jessesquires commented Jul 26, 2016

After we merge this, would you be interested helping with the following:

  1. merging develop into swift2.3, migrate, submit PR
  2. then merging swift2.3 into swift3.0, migrate, submit PR

No pressure if you don't have time, or don't want to! 😊 I can take care of this. Just wanted to ask.

@dcaunt
Copy link
Copy Markdown
Collaborator Author

dcaunt commented Jul 26, 2016

Yes, I can migrate this PR to the other Swift versions, it's not much work :)

@jessesquires jessesquires merged commit e996c2b into jessesquires:develop Jul 27, 2016
@jessesquires
Copy link
Copy Markdown
Owner

Thanks @dcaunt ! 🎉

@dcaunt dcaunt deleted the composed-cell-example branch July 27, 2016 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants