Skip to content
This repository was archived by the owner on Apr 15, 2020. It is now read-only.

Don't build tests when building Example with Carthage#62

Merged
jessesquires merged 1 commit into
jessesquires:developfrom
dcaunt:issue_61_fix_carthage_build
Aug 9, 2016
Merged

Don't build tests when building Example with Carthage#62
jessesquires merged 1 commit into
jessesquires:developfrom
dcaunt:issue_61_fix_carthage_build

Conversation

@dcaunt
Copy link
Copy Markdown
Collaborator

@dcaunt dcaunt commented Aug 9, 2016

Pull request checklist

This fixes issue #61.

What's in this pull request?

Update scheme not to build Example unit tests when building Example project.

Carthage users would benefit from a 4.0.1 release including this fix.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 9, 2016

Current coverage is 89.04% (diff: 100%)

Merging #62 into develop will not change coverage

@@            develop        #62   diff @@
==========================================
  Files             9          9          
  Lines           365        365          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            325        325          
  Misses           40         40          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update e996c2b...c0b5105

@jessesquires
Copy link
Copy Markdown
Owner

Thanks @dcaunt ! 🎉 👍

@jessesquires jessesquires added this to the 4.0.1 milestone Aug 9, 2016
@jessesquires jessesquires merged commit aa7b91a into jessesquires:develop Aug 9, 2016
@jessesquires
Copy link
Copy Markdown
Owner

4.0.1: https://github.com/jessesquires/JSQDataSourcesKit/releases/tag/4.0.1

Pushing to cocoapods now.

@dcaunt - I really appreciate the great PRs! Going to send you an invite to be a collaborator 😄

@dcaunt dcaunt deleted the issue_61_fix_carthage_build branch August 9, 2016 17:25
@dcaunt
Copy link
Copy Markdown
Collaborator Author

dcaunt commented Aug 9, 2016

Happy to help. I have accepted, hope I can continue to be useful!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants