This repository was archived by the owner on Apr 15, 2020. It is now read-only.
make DataSourceProtocol.item(atIndexPath: ) public#76
Merged
Conversation
Current coverage is 93.37% (diff: 100%)@@ develop #76 diff @@
==========================================
Files 9 9
Lines 360 362 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 336 338 +2
Misses 24 24
Partials 0 0
|
dcaunt
reviewed
Dec 12, 2016
|
|
||
| /// :nodoc: | ||
| public func item(atIndexPath indexPath: IndexPath) -> Item? { | ||
| return object(at: indexPath) as? T |
Collaborator
There was a problem hiding this comment.
Nit – should be as? Item for consistency?
dcaunt
approved these changes
Dec 12, 2016
Collaborator
dcaunt
left a comment
dcaunt
left a comment
There was a problem hiding this comment.
Good catch! Just a minor note.
Collaborator
|
|
Owner
Author
|
i guess i should write a couple of tests, too 😅 |
Owner
Author
|
thanks @dcaunt ! 💯 |
3 tasks
jessesquires
force-pushed
the
datasource-indexpath
branch
from
1967cd5 to
3278d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lol whoops. 😳 This was intended to be
public.