docs: fix wrong MockFunctions.md log result#11588
docs: fix wrong MockFunctions.md log result#11588iibe wants to merge 1 commit intojestjs:masterfrom iibe:fix-mock-functions-doc
Conversation
It seems a little strange to me. Why are we showing the first and second arguments of the first function call (lines 108-109 of the MockFunctions.md). It would be more correct to write .calls[0][0] and .calls[1][0] to show the first argument of funtion calls. MockFunctions.md typo fixed
|
Hi @iibe! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #11588 +/- ##
=======================================
Coverage 69.00% 69.00%
=======================================
Files 312 312
Lines 16331 16331
Branches 4730 4730
=======================================
Hits 11269 11269
Misses 5034 5034
Partials 28 28 Continue to review full report at Codecov.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Same as #11556 |
|
Hmm, yeah. Thanks. I didn't notice it. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It seems a little strange to me. Why are we showing the first and second arguments of the first function call (lines 108-109 of the MockFunctions.md). It would be more correct to write .calls[0][0] and .calls[1][0] to show the first argument of function

calls.
MockFunctions.md typo fixed
Summary
It fixes documentation typo. Therefore, the reader will correctly understand the text if we fix this typo.
Test plan
http://prntscr.com/15t2xmb