Skip to content

Add support for the VenafiConnection CRD so that users can start using the Workload Identity Federation authentication ("secretless") #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maelvls merged 16 commits into from
Aug 22, 2024
Merged

Add support for the VenafiConnection CRD so that users can start using the Workload Identity Federation authentication ("secretless") #552

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
67efc9c
venconn: update the Go dependencies so that we can use venafi-connect…
maelvls Jul 3, 2024
55c3ab1
venconn: add support for VenafiConnection CRD with --venafi-connectio…
maelvls Jul 16, 2024
2e5a0f8
venconn: ignore config's venafi-cloud.upload_path and uploader_id
maelvls Jul 25, 2024
01641b1
misc: explain what is the difference between "cluster id" and "cluste…
maelvls Jul 26, 2024
baa1def
venconn: remove unused Post and PostDataReadings in Venafi Connection…
maelvls Jul 26, 2024
39e1765
venconn: test NewVenConnClient and PostDataReadingsWithOptions
maelvls Aug 12, 2024
7c91430
venconn: switch to venafi-connection-lib@main instead of v0.1.0 for now
maelvls Aug 13, 2024
571a3a0
venconn: add integration tests using envtest
maelvls Aug 20, 2024
aa41af2
github actions, go.mod: use Go 1.22 instead of the unsupported 1.19
maelvls Aug 13, 2024
d9939b7
github actions: configure DEPLOY_KEY_READ_VENAFI_CONNECTION_LIB
maelvls Aug 19, 2024
4d4dbc9
venconn: builder.dockerfile: go mod download needs access to venafi-c…
maelvls Aug 19, 2024
5190b59
misc: fix log line missed in #558
maelvls Aug 20, 2024
10126b4
github actions: use the ssh-agent action to handle the deploy key
maelvls Aug 20, 2024
f1f175c
venconn test: use the template CRD temporarily
maelvls Aug 20, 2024
804d81d
address review feedback: error unchecked in client_venconn_test.go
maelvls Aug 22, 2024
9b0e619
Add missing VenafiConnection templates and values to the Helm chart
wallrj Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
venconn test: use the template CRD temporarily
  • Loading branch information
@maelvls
maelvls committed Aug 20, 2024
commit f1f175cc27f78ae8b74f3eaa9e77a02540fc0c46
5 changes: 4 additions & 1 deletion pkg/client/client_venconn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,10 @@ func fakeTPP(t testing.TB) (*httptest.Server, *x509.Certificate) {
func startEnvtest(t testing.TB) (_ *envtest.Environment, _ *rest.Config, kclient ctrlruntime.WithWatch) {
envtest := &envtest.Environment{
ErrorIfCRDPathMissing: true,
CRDDirectoryPaths: []string{"../../deploy/charts/venafi-kubernetes-agent/crd_bases/jetstack.io_venaficonnections.yaml"},
// TODO(mael): Once the automation around generating the CRD is in
// place, remember to update this path to
// deploy/charts/venafi-kubernetes-agent/crd_bases/jetstack.io_venaficonnections.yaml
CRDDirectoryPaths: []string{"../../deploy/charts/venafi-kubernetes-agent/templates/venafi-connection-crd.yaml"},
}
restconf, err := envtest.Start()
require.NoError(t, err)
Expand Down