Skip to content

VC-36351: Include namespaces as part of the resources to be collected #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maelvls merged 1 commit into from
Oct 3, 2024
Merged

VC-36351: Include namespaces as part of the resources to be collected #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions deploy/charts/venafi-kubernetes-agent/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ data:
resource-type:
resource: pods
version: v1
- kind: "k8s-dynamic"
name: "k8s/namespaces"
config:
resource-type:
resource: namespaces
version: v1
Copy link
Member

@wallrj wallrj Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the other resource types there is a corresponding RBAC ClusterRole and ClusterRoleBinding which explicitly grants permission to the the agent service account to read those resources.

Do service accounts implicitly have permission to list namespaces?

The RBAC ClusterRole was also omitted in #507

# gather services for pod readiness probe rules
- kind: "k8s-dynamic"
name: "k8s/services"
Expand Down