[VC-35738] Define well known log verbosity values and log less by default#617
Merged
wallrj merged 1 commit intoVC-35738/featurefrom Nov 14, 2024
Merged
[VC-35738] Define well known log verbosity values and log less by default#617wallrj merged 1 commit intoVC-35738/featurefrom
wallrj merged 1 commit intoVC-35738/featurefrom
Conversation
wallrj
changed the title
wallrj
force-pushed
the
VC-35738/info-debug-trace
branch
from
48372bd to
7d19d0a
Compare
maelvls
reviewed
Nov 14, 2024
| if f.Name == "v" { | ||
| f.Name = "log-level" | ||
| f.Shorthand = "v" | ||
| f.Usage = fmt.Sprintf("%s. 0=Info, 1=Debug, 2=Trace. Use 3-10 for even greater detail. (default: 0)", f.Usage) |
Member
There was a problem hiding this comment.
Thanks for documenting this in --help, this is much appreciated!
maelvls
approved these changes
Nov 14, 2024
Member
maelvls
left a comment
maelvls
left a comment
There was a problem hiding this comment.
This PR doesn't change any logic, so I'm super confident that nothing will break; I don't think it needs extra testing from my end.
Base automatically changed from
VC-35738/remove-logs-dot-log-2
to
VC-35738/feature
November 14, 2024 11:38
Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj
force-pushed
the
VC-35738/info-debug-trace
branch
from
7d19d0a to
1402d52
Compare
wallrj
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aims of this PR are:
--verbosityvalues mean in practice.--verbosityvalue is.V()value to use when they add new log messages.V()values more consistent.