Skip to content

Upgrade gradle from 5.6.4 to 7.6.4#392

Merged
yahavi merged 2 commits into
jfrog:devfrom
j-sandy:master
Oct 3, 2024
Merged

Upgrade gradle from 5.6.4 to 7.6.4#392
yahavi merged 2 commits into
jfrog:devfrom
j-sandy:master

Conversation

@j-sandy

@j-sandy j-sandy commented Sep 23, 2024

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.

@github-actions

github-actions Bot commented Sep 23, 2024

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@j-sandy

j-sandy commented Sep 24, 2024

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@j-sandy

j-sandy commented Sep 24, 2024

Copy link
Copy Markdown
Contributor Author

recheck

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Sep 24, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Sep 24, 2024
@yahavi

yahavi commented Sep 24, 2024

Copy link
Copy Markdown
Member

@j-sandy - what is the reason for this change?

@j-sandy

j-sandy commented Sep 24, 2024

Copy link
Copy Markdown
Contributor Author

@j-sandy - what is the reason for this change?

@yahavi We are upgrading Spinnaker, an open-source continuous delivery platform, to adopt groovy 4. This activity is part of a bigger mission to reduce the vulnerabilities and making Spinnaker secure.
Jfrog artifactory java client is used as one of the dependency in a Spinnaker component, it brings groovy 2 as its transitive dependency, so in order to avoid exclusion of groovy from this package and to contribute back our experiences of groovy upgrades, we would like to upgrade the package to groovy 4.
And gradle upgrade is first step towards it.
Please suggest, if any, limitations in this approach.

@j-sandy

j-sandy commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

@yahavi Should I raise PR to dev branch first for gradle upgrade ?

@yahavi
yahavi changed the base branch from master to dev September 27, 2024 14:17
@yahavi

yahavi commented Sep 27, 2024

Copy link
Copy Markdown
Member

@j-sandy
I don't see any limitations for upgrading to Gradle 7. However, 7.6.1 is not the latest patch version. Would you like to upgrade to 7.6.4 instead?

@j-sandy j-sandy changed the title Upgrade gradle from 5.6.4 to 7.6.1 Upgrade gradle from 5.6.4 to 7.6.4 Sep 30, 2024
@j-sandy

j-sandy commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@j-sandy

j-sandy commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

recheck

@j-sandy

j-sandy commented Oct 1, 2024

Copy link
Copy Markdown
Contributor Author

@yahavi Could you please help to initiate the build ? Or please let me know if I missed any requirement to proceed.

@yahavi yahavi added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Oct 1, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Oct 1, 2024

@yahavi yahavi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @j-sandy!

@yahavi
yahavi merged commit aa9789c into jfrog:dev Oct 3, 2024
@yahavi yahavi added improvement Automatically generated release notes and removed ignore for release Automatically generated release notes labels Oct 3, 2024
@yahavi

yahavi commented Oct 3, 2024

Copy link
Copy Markdown
Member

@j-sandy
Artifactory Java client version 2.19.0 has been released. This version was built using Gradle 7.6.4.
Let us know if it works for you!

@j-sandy

j-sandy commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @yahavi !
It is a useful improvement towards the final goal of groovy 4 upgrade. I will be raising another PR to upgrade groovy 2.x to 4.x.
Appreciate your kind support.

@j-sandy

j-sandy commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

#394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants