Skip to content

Add Info to SCA Issue Node and Improve Applicability Enum String Value#172

Merged
kerenr-jfrog merged 3 commits intojfrog:masterfrom
kerenr-jfrog:add-info-to-sca-issue-node
Apr 6, 2025
Merged

Add Info to SCA Issue Node and Improve Applicability Enum String Value#172
kerenr-jfrog merged 3 commits intojfrog:masterfrom
kerenr-jfrog:add-info-to-sca-issue-node

Conversation

@kerenr-jfrog
Copy link
Copy Markdown
Contributor

@kerenr-jfrog kerenr-jfrog commented Apr 6, 2025 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • Added missing info for presenting SCA issues - component name and version.
  • Use the help field instead of full description when parsing SCA results.
  • Changed Applicability names to be more readable for usage in IDEs UI.

@kerenr-jfrog kerenr-jfrog added the improvement Automatically generated release notes label Apr 6, 2025
@kerenr-jfrog kerenr-jfrog self-assigned this Apr 6, 2025
@kerenr-jfrog kerenr-jfrog added the safe to test run tests label Apr 6, 2025
@github-actions github-actions Bot removed the safe to test run tests label Apr 6, 2025
@kerenr-jfrog kerenr-jfrog changed the title Add info to sca issue node Add info to sca issue node + Applicability name change Apr 6, 2025
@kerenr-jfrog kerenr-jfrog changed the title Add info to sca issue node + Applicability name change Add Info to SCA Issue Node and Improve Applicability Enum String Value Apr 6, 2025
@kerenr-jfrog kerenr-jfrog marked this pull request as ready for review April 6, 2025 12:21
hadarshjfrog
hadarshjfrog approved these changes Apr 6, 2025
View reviewed changes
Copy link
Copy Markdown

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a minor comment

Comment thread src/main/java/com/jfrog/ide/common/nodes/ScaIssueNode.java
@kerenr-jfrog kerenr-jfrog added the safe to test run tests label Apr 6, 2025
@github-actions github-actions Bot removed the safe to test run tests label Apr 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@kerenr-jfrog kerenr-jfrog merged commit 000b150 into jfrog:master Apr 6, 2025
20 checks passed
@kerenr-jfrog kerenr-jfrog deleted the add-info-to-sca-issue-node branch April 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas Awaiting requested review from attiasas

1 more reviewer

@hadarshjfrog hadarshjfrog hadarshjfrog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kerenr-jfrog kerenr-jfrog

Labels

improvement Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kerenr-jfrog @hadarshjfrog