Update include dir as false if dry-run is setted to prevent the false…#350
Merged
naveenku-jfrog merged 6 commits intojfrog:mainfrom Jan 27, 2026
Conversation
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
itsmeleela
reviewed
Jan 23, 2026
| if err != nil { | ||
| return | ||
| } | ||
| uploadParams.IncludeDirs = includeDirs && !dryRun |
Collaborator
There was a problem hiding this comment.
I feel we somewhere need to log that --include-dirs flag is ignored as it is dry run
Collaborator
Author
There was a problem hiding this comment.
Addressed it.
itsmeleela
reviewed
Jan 23, 2026
| @@ -233,10 +230,12 @@ func getUploadParams(f *spec.File, configuration *utils.UploadConfiguration, bui | |||
| return | |||
| } | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Also, isn't it much easier just to say
if dryRun {
uploadParams.IncludeDirs = false
}
Collaborator
Author
There was a problem hiding this comment.
This way we have to use one more if condition to set include-dir flag if dry-run flag is not set. So, current implementation looks correct.
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
4 tasks
bhanurp
requested changes
Jan 26, 2026
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
Contributor
itsmeleela
approved these changes
Jan 27, 2026
naveenku-jfrog
added a commit
to naveenku-jfrog/jfrog-cli-artifactory
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what: Update include dir as false if dry-run is set to prevent the false upload