Added Scan management logic to perform Audit scans using Jfrog Cli #33
Merged
kerenr-jfrog merged 9 commits intojfrog:V2from Apr 6, 2025
Merged
Added Scan management logic to perform Audit scans using Jfrog Cli #33kerenr-jfrog merged 9 commits intojfrog:V2from
kerenr-jfrog merged 9 commits intojfrog:V2from
Conversation
hadarshjfrog
reviewed
Apr 2, 2025
hadarshjfrog
left a comment
There was a problem hiding this comment.
looking good - basically minor cleanups
attiasas
requested changes
Apr 3, 2025
attiasas
left a comment
There was a problem hiding this comment.
Nice! check out my comments. In addition:
- make sure you format the changes, I can see some missing spacing in some places
- is it possible to start adding tests at this stage?
attiasas
reviewed
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.