Skip to content

[RN 0.56] Context menu functions are broken #244

@jhen0409

Description

@jhen0409

Looks like react/react-native#18995 breaks the global window.require usage, so context menu will be broken with related modules.

Here is the expected solution for update RNDebugger:

  • MessageQueue: We can use Object.getPrototypeOf(__fbBatchedBridge).constructor instead
  • setupDevtools: It used for backward compatible (RN < 0.39), just remove that as latest version of react-devtools have been removed the backward compatible
  • Other modules: We can change to use window.require(1), 1 is the ReactNative module id, but I'm yet to sure if some case will change the module id

We should also update the documentation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions