fix: Add proper picocli argument completion via AutoComplete#1708
Merged
fix: Add proper picocli argument completion via AutoComplete#1708
Conversation
The PicocliCommandRegistry only completed command/option names using a simple StringsCompleter. This missed option values, positional parameters, completion candidates, and nested subcommand arguments. Changes: - Add Command.completer() method for non-positional completion strategies - DefaultCommandDispatcher checks cmd.completer() before falling back to the position-based completers() list - PicocliCommandRegistry now uses picocli's AutoComplete.complete() which properly handles all completion types: options, option values, positional parameters with completion candidates, and nested subcommands Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
gnodet
added a commit
to apache/camel
that referenced
this pull request
Mar 23, 2026
JLine 4.0.8 includes jline/jline3#1708 which fixes PicocliCommandRegistry to use picocli's AutoComplete for proper tab completion of options, option values, positional parameters, and nested subcommands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
to apache/camel
that referenced
this pull request
Mar 23, 2026
JLine 4.0.8 includes jline/jline3#1708 which fixes PicocliCommandRegistry to use picocli's AutoComplete for proper tab completion of options, option values, positional parameters, and nested subcommands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PicocliCommandRegistryonly completed command and option names using a simpleStringsCompleter. This missed:Changes
Command.java: Addcompleter()default method that returns a singleCompleterfor non-positional completion strategies (e.g., picocli commands where options can appear in any order)DefaultCommandDispatcher.java: Checkcmd.completer()first before falling back to the position-basedcompleters()list wrapped inArgumentCompleterPicocliCommandRegistry.java: Use picocli'sAutoComplete.complete()in bothcompileCompleters()(legacyCommandRegistrypath) andPicocliCommand.completer()(newCommandGrouppath), which properly handles all completion typesTest plan